After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679782 - Remove markup in translatable messages
Remove markup in translatable messages
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2012-07-12 06:20 UTC by Jiro Matsuzawa
Modified: 2012-07-12 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch for this bug (2.20 KB, patch)
2012-07-12 06:20 UTC, Jiro Matsuzawa 		accepted-commit_now Details | Review

Description Jiro Matsuzawa 2012-07-12 06:20:03 UTC 
Created attachment 218605 [details] [review]
a patch for this bug

The attached patch removes markup in translatable messages.
It's for the GNOME Goal of RemoveMarkupInMessages [1].
Please review it.

[1] https://live.gnome.org/GnomeGoals/RemoveMarkupInMessages
Comment 1 Robert Ancell 2012-07-12 09:04:18 UTC 
Review of attachment 218605 [details] [review]:

In this patch you have just removed the markup, not made just the non markup part of the string translatable.  There appears to be a fix for this in Glade/GTK (https://bugzilla.gnome.org/show_bug.cgi?id=97061) or you need to set the text in the gcalctool code.
Comment 2 Robert Ancell 2012-07-12 09:05:05 UTC 
Review of attachment 218605 [details] [review]:

Oh, sorry.  Now I read the patch more closely it does look correct!
Comment 3 Jiro Matsuzawa 2012-07-12 10:44:02 UTC 
I've pushed it.
http://git.gnome.org/browse/gcalctool/commit/?id=37d02d608dd16084c9d21cf29806664b26feccbd

Thank you!