GNOME Bugzilla – Bug 67966
Support for recently viewed
Last modified: 2006-06-10 17:22:42 UTC
Add support for a recently-viewed list.
Mass moving Yelp bugs to new maintainer.
Let me work on this..
Any progress on this?
Created attachment 53599 [details] [review] Recently Viewed Lists Patch for recently viewed lists from the forward and back buttons. It uses the window title as the list entry. The final bit of the patch (for stylesheets/man2html.xsl) makes the title appear for man pages, otherwise it'll show up as "Unknow Page"
Cleaned up some of the bitrot on this patch. I like the idea, but it's hard to differentiate between what the different pages are that you've been to. I think an indication of whether it was a TOC page, a docbook file, man page, info page or otherwise would make this patch more useable. I am attaching the cleaned up patch - I removed the change to man2html.xsl since that has already been fixed in head. Also I get these warnings when compiling: yelp-window.c: In function ‘history_push_back’: yelp-window.c:570: warning: passing argument 1 of ‘gtk_window_get_title’ from incompatible pointer type yelp-window.c:570: warning: assignment discards qualifiers from pointer target type yelp-window.c:588: warning: passing argument 1 of ‘gtk_menu_shell_prepend’ from incompatible pointer type yelp-window.c: In function ‘history_push_forward’: yelp-window.c:616: warning: passing argument 1 of ‘gtk_window_get_title’ from incompatible pointer type yelp-window.c:616: warning: assignment discards qualifiers from pointer target type yelp-window.c:633: warning: passing argument 1 of ‘gtk_menu_shell_prepend’ from incompatible pointer type yelp-window.c: In function ‘history_back_to’: yelp-window.c:772: warning: passing argument 1 of ‘gtk_container_remove’ from incompatible pointer type yelp-window.c:781: warning: passing argument 1 of ‘gtk_menu_shell_prepend’ from incompatible pointer type yelp-window.c: In function ‘history_forward_to’: yelp-window.c:820: warning: passing argument 1 of ‘gtk_container_remove’ from incompatible pointer type yelp-window.c:828: warning: passing argument 1 of ‘gtk_menu_shell_prepend’ from incompatible pointer type yelp-window.c: In function ‘window_populate’: yelp-window.c:1237: warning: passing argument 2 of ‘gtk_toolbar_insert’ from incompatible pointer type yelp-window.c:1238: warning: passing argument 2 of ‘gtk_toolbar_insert’ from incompatible pointer type yelp-window.c:1243: warning: passing argument 1 of ‘gtk_container_remove’ from incompatible pointer type yelp-window.c: At top level:
Created attachment 56903 [details] [review] cleaned up DonS's patch DonS: please take a look - there were three hunks which failed in yelp-window.c - I think I merged them correctly, but I'm not sure about the ordering from yelp-window.c:1233-1243.
Marking needs work as I would like to see an indication (icon maybe?) in the history list that tells you what that particular item is (man page, info page, TOC page, or db page)
Path has now been applied to CVS. Some work is still needed on it, but it has been applied. Closing.