After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679455 - Port to GStreamer 1.0
Port to GStreamer 1.0
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks: 679412
 
 
Reported: 2012-07-05 15:02 UTC by Sebastian Dröge (slomo)
Modified: 2012-07-24 15:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Do initial port to GStreamer 1.0 (6.30 KB, patch)
2012-07-10 16:04 UTC, Sebastian Dröge (slomo)
reviewed Details | Review
Don't set an audiosink on playbin for the preview and have a fake videosink (1.58 KB, patch)
2012-07-10 16:04 UTC, Sebastian Dröge (slomo)
reviewed Details | Review
Use playbin for the CD playback feature (6.27 KB, patch)
2012-07-10 16:04 UTC, Sebastian Dröge (slomo)
reviewed Details | Review
Do initial port to GStreamer 1.0 (6.30 KB, patch)
2012-07-16 07:49 UTC, Sebastian Dröge (slomo)
committed Details | Review
Don't set an audiosink on playbin for the preview and disable video output (2.04 KB, patch)
2012-07-16 07:50 UTC, Sebastian Dröge (slomo)
committed Details | Review
Use playbin for the CD playback feature (6.39 KB, patch)
2012-07-16 07:50 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2012-07-05 15:02:10 UTC
Hi,
at http://cgit.collabora.com/git/user/slomo/sound-juicer.git/log/?h=gst-1.0 you can find a port of sound-juicer to GStreamer 1.0 (+ some cleanups). The only regression is that the CD player feature does not set the profile on the audio-sink anymore (see http://cgit.collabora.com/git/user/slomo/sound-juicer.git/tree/src/sj-play.c?h=475dafcbedee8d6d9adf5b5b9836ad552c2198d7#n369 )

This could be solved but it's already inconsistent elsewhere too (the egg play preview thing for example). Is this necessary, should this be done everywhere too? It can also be done globally for pulseaudio by using an environment variable btw.
Comment 1 Bastien Nocera 2012-07-10 15:57:55 UTC
Sebastian, could you attach the patches here for review? (git-bz or git-bugzilla look like good helpers for that)
Comment 2 Sebastian Dröge (slomo) 2012-07-10 16:04:16 UTC
Created attachment 218440 [details] [review]
Do initial port to GStreamer 1.0
Comment 3 Sebastian Dröge (slomo) 2012-07-10 16:04:19 UTC
Created attachment 218441 [details] [review]
Don't set an audiosink on playbin for the preview and have a fake videosink

This will make sure that the optimal audio sink is chosen and no video
is played whatsoever.
Comment 4 Sebastian Dröge (slomo) 2012-07-10 16:04:22 UTC
Created attachment 218442 [details] [review]
Use playbin for the CD playback feature
Comment 5 Bastien Nocera 2012-07-12 13:37:48 UTC
Review of attachment 218440 [details] [review]:

Looks good.
Comment 6 Bastien Nocera 2012-07-12 13:38:59 UTC
Review of attachment 218441 [details] [review]:

Would it make sense to disable the video decoding part of playbin through flags?
Comment 7 Bastien Nocera 2012-07-12 13:48:11 UTC
Review of attachment 218442 [details] [review]:

Looks alright.

::: src/sj-play.c
@@ +369,2 @@
+    /* FIXME: Try this on the audiosink */
+#if 0

Remove the code instead?
Comment 8 Sebastian Dröge (slomo) 2012-07-16 07:30:35 UTC
(In reply to comment #6)
> Review of attachment 218441 [details] [review]:
> 
> Would it make sense to disable the video decoding part of playbin through
> flags?

Of course, thanks :) Will attach new patches soon

(In reply to comment #7)
> Review of attachment 218442 [details] [review]:
> 
> Looks alright.
> 
> ::: src/sj-play.c
> @@ +369,2 @@
> +    /* FIXME: Try this on the audiosink */
> +#if 0
> 
> Remove the code instead?

Will do
Comment 9 Sebastian Dröge (slomo) 2012-07-16 07:49:58 UTC
Created attachment 218884 [details] [review]
Do initial port to GStreamer 1.0
Comment 10 Sebastian Dröge (slomo) 2012-07-16 07:50:01 UTC
Created attachment 218885 [details] [review]
Don't set an audiosink on playbin for the preview and disable video output

This will make sure that the optimal audio sink is chosen and no video
is played whatsoever.
Comment 11 Sebastian Dröge (slomo) 2012-07-16 07:50:04 UTC
Created attachment 218886 [details] [review]
Use playbin for the CD playback feature
Comment 12 Ross Burton 2012-07-24 15:07:28 UTC
Review of attachment 218886 [details] [review]:

Fine.
Comment 13 Ross Burton 2012-07-24 15:07:51 UTC
Review of attachment 218885 [details] [review]:

Fine.
Comment 14 Ross Burton 2012-07-24 15:08:41 UTC
Review of attachment 218884 [details] [review]:

Fine.
Comment 15 Sebastian Dröge (slomo) 2012-07-24 15:22:45 UTC
Thanks