After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 679356 - Sidebar width is too flexible
Sidebar width is too flexible
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Sidebar
3.16.x
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 748397 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-07-03 21:47 UTC by António Fernandes
Modified: 2016-10-16 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Too narrow (37.19 KB, image/png)
2012-07-03 21:47 UTC, António Fernandes
Details
Too wide (48.94 KB, image/png)
2012-07-03 21:51 UTC, António Fernandes
Details
Too wide (20.02 KB, image/png)
2015-08-22 15:01 UTC, António Fernandes
Details

Description António Fernandes 2012-07-03 21:47:39 UTC
Created attachment 217970 [details]
Too narrow

As reproduced in the attachments, the ability to change the sidebar width can be problematic up to the point where it breaks the interface aesthetics and usability. 

A reasonable minimum size was proposed on bug 311732, but there is no longer a header combobox. As such, I propose a minimum width such that no section header ("Places", "Devices", "Bookmarks", "Network") is ellipsed.

Proposed maximum would be such that no text in the sidebar is ellipsed.
Comment 1 António Fernandes 2012-07-03 21:51:20 UTC
Created attachment 217971 [details]
Too wide

The maximum width results in a broken UI, reproduced by this attachment.
Comment 2 André Klapper 2012-07-09 10:05:32 UTC
Which version is this about? COuld you please set the version field?
Comment 3 António Fernandes 2012-07-09 10:24:49 UTC
The issue itself is not about any specific version. I just reproduced it in 3.4.2 and I remember doing it in earlier versions. For that reason, I left the version unspecified.

Screenshots were from git master, so I will set that.
Comment 4 Cosimo Cecchi 2012-07-20 15:03:07 UTC
Mass changing component for BZ cleanup, sorry for the spam.
Comment 5 Robert Roth 2015-01-19 08:13:09 UTC
Minimum size request seems better now (although some items are still ellipsized, and there are no section headers anymore). I don't know if setting a maximum size for the sidebar would make sense, but setting a minimum size for the icon/list view might make more sense:
Currently when scaling the window to its minimum size and resizing the sidebar to it's minimum the proportions are 1/4 width sidebar + 3/4 width icon/list view. Maybe setting an icon/list view minimum width request = 3/4 *currently set minimum window width would solve this issue.
Comment 6 António Fernandes 2015-04-24 10:03:07 UTC
*** Bug 748397 has been marked as a duplicate of this bug. ***
Comment 7 Carlos Soriano 2015-04-27 11:01:07 UTC
a good solution is allow a little more (for the sake of freedom) than the largest label width.
Will take a look for 3.18
Comment 8 Matthias Clasen 2015-08-22 14:45:13 UTC
Is this still relevant, or did all the places sidebar and places view work obsolete this ?
Comment 9 António Fernandes 2015-08-22 15:01:34 UTC
Created attachment 309864 [details]
Too wide

(In reply to Matthias Clasen from comment #8)

The "too narrow" case is fixed, indeed.

The "too wide" case is still reproducible in git master (see attachment). The sidebar can be made as wide as the window itself.
Comment 10 Carlos Soriano 2015-08-31 11:41:45 UTC
I'm still unsure about restricting this for GtkPlacesSidebar clients, although I agree it doesn't make much sense to allow it.

Matthias, Allan, do you have some opinion?
Comment 11 Carlos Soriano 2015-09-01 14:05:43 UTC
Releasing the 3.18 target, the biggest issue (minimum width) is fixed.
Comment 12 Ernestas Kulik 2016-10-16 20:48:52 UTC
The patch in bug 767573 fixed this.