After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677640 - Add 'screensaver.show-notifications' settings
Add 'screensaver.show-notifications' settings
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 619955
 
 
Reported: 2012-06-07 17:30 UTC by Giovanni Campagna
Modified: 2012-06-08 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screensaver: add show-notifications setting (1.45 KB, patch)
2012-06-07 17:30 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2012-06-07 17:30:15 UTC
To be used by gnome-shell
Comment 1 Giovanni Campagna 2012-06-07 17:30:31 UTC
Created attachment 215859 [details] [review]
screensaver: add show-notifications setting

This controls whether the screen lock in gnome-shell will show
a summary of unacknowledged notifications or not. It defaults
to false, to protect the user's privacy.
Comment 2 Matthias Clasen 2012-06-07 20:10:33 UTC
Review of attachment 215859 [details] [review]:

Looks fine to me.
I assume we will reuse this key for the global switch when https://live.gnome.org/Design/SystemSettings/Notifications gets implemented ?
Comment 3 Giovanni Campagna 2012-06-07 20:23:45 UTC
Yeah, that would make sense.
Although that's probably 3.8 stuff.
Comment 4 Giovanni Campagna 2012-06-07 20:28:31 UTC
Attachment 215859 [details] pushed as 86e9138 - screensaver: add show-notifications setting
Comment 5 Bastien Nocera 2012-06-08 10:00:18 UTC
Review of attachment 215859 [details] [review]:

::: schemas/org.gnome.desktop.screensaver.gschema.xml.in.in
@@ +19,3 @@
+      <default>false</default>
+      <_summary>Show notifications in the lock screen</_summary>
+      <_description>Whether notifications are shown in the lock screen or not. This only affects the standard experience.</_description>

If it only affects the "standard experience", why does it need to be here?
Comment 6 Giovanni Campagna 2012-06-08 10:19:42 UTC
IMO, because it makes sense to consolidate all related settings in one place instead of scattering them around.
Also, having gnome-control-center depend on org.gnome.shell is a problem for some environments (Ubuntu), and we don't want them to patch g-c-c.
Comment 7 Bastien Nocera 2012-06-08 10:48:42 UTC
Fine then. I'd like to see this sort of reasoning ahead of time in the future, as we really don't want to be adding things to gsettings-desktop-schemas that we won't be able to remove for ages.