GNOME Bugzilla – Bug 677640
Add 'screensaver.show-notifications' settings
Last modified: 2012-06-08 10:48:42 UTC
To be used by gnome-shell
Created attachment 215859 [details] [review] screensaver: add show-notifications setting This controls whether the screen lock in gnome-shell will show a summary of unacknowledged notifications or not. It defaults to false, to protect the user's privacy.
Review of attachment 215859 [details] [review]: Looks fine to me. I assume we will reuse this key for the global switch when https://live.gnome.org/Design/SystemSettings/Notifications gets implemented ?
Yeah, that would make sense. Although that's probably 3.8 stuff.
Attachment 215859 [details] pushed as 86e9138 - screensaver: add show-notifications setting
Review of attachment 215859 [details] [review]: ::: schemas/org.gnome.desktop.screensaver.gschema.xml.in.in @@ +19,3 @@ + <default>false</default> + <_summary>Show notifications in the lock screen</_summary> + <_description>Whether notifications are shown in the lock screen or not. This only affects the standard experience.</_description> If it only affects the "standard experience", why does it need to be here?
IMO, because it makes sense to consolidate all related settings in one place instead of scattering them around. Also, having gnome-control-center depend on org.gnome.shell is a problem for some environments (Ubuntu), and we don't want them to patch g-c-c.
Fine then. I'd like to see this sort of reasoning ahead of time in the future, as we really don't want to be adding things to gsettings-desktop-schemas that we won't be able to remove for ages.