After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677115 - Add disable-mouse-modifiers message for Sugar
Add disable-mouse-modifiers message for Sugar
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: High critical
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2012-05-30 17:03 UTC by Daniel Drake
Modified: 2012-06-07 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (6.10 KB, patch)
2012-05-30 17:03 UTC, Daniel Drake
reviewed Details | Review

Description Daniel Drake 2012-05-30 17:03:55 UTC
Created attachment 215269 [details] [review]
patch

Sugar would like a runtime way of disable mouse button modifiers, like what already exists for key bindings. Here's a patch to make that happen.
Comment 1 Daniel Drake 2012-06-06 17:32:30 UTC
Just to add some extra info: We never saw this before because the mouse modifier was mapped by default to the Super key, which we don't have.  In recent GNOME versions it is now mapped to Alt, which we use in Sugar for something else: http://dev.laptop.org/ticket/11781

We could use gsettings to unmap this key, but this is undesirable because it would affect GNOME. We run Sugar and GNOME from the same user account (sharing documents, settings, etc).
Comment 2 Florian Müllner 2012-06-07 14:42:33 UTC
Review of attachment 215269 [details] [review]:

Not sure I'm really happy with metacity-message being used as preference alternative rather than a debugging tool, but the code looks good, so go ahead :-)

::: src/core/keybindings.h
@@ +53,3 @@
                                              gboolean     setting);
+void     meta_set_mousemods_disabled        (MetaDisplay *display,
+                                             gboolean     setting);

not really related to keybindings - is there a better header file?
Comment 3 Daniel Drake 2012-06-07 15:21:48 UTC
No header change was needed in the end - that part is self-contained in display.c so I made it static.

Thanks for being flexible - hopefully this is the last strange request Sugar will need :)

Pushed as 86fd12c