GNOME Bugzilla – Bug 676656
toolbar isn't well defined in panels
Last modified: 2013-02-18 18:03:45 UTC
In a panel the toolbar isn't visually distinct from the rest of the panel.
Yes, something needs to be done here. Right now the grid button looks like it is part of the panels rather than belonging to the g-c-c shell. There have been a few attempts to come up with a visual treatment for this bug, including a simple line along the bottom edge of the toolbar [1], potentially in combination with a different background color for the panels [2]. I'd be happy with the former approach, provided that it doesn't look too heavy. [1] https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/date-and-time/date-and-time-hi-res.png [2] https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/power/power-hi-res.png
This is a theming problem IMO. We already use a GtkToolBar here.
Also see bug 692174
Created attachment 235502 [details] [review] shell: define a style class for the notebook and remove the shadow Define a style class for the notebook and remove the shadow to allow the border to be set from the theme.
Review of attachment 235502 [details] [review]: This patch defines a style class for the widget below the toolbar, as implemented in other applications that have a visual separator between the toolbar and the application content. The styling would still need to be added to the theme after this patch is applied.
This is fixed in master, since CC now uses a GdHeaderBar and the theme gained a styling for that similar to the mockups mentioned in this report.