After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 676656 - toolbar isn't well defined in panels
toolbar isn't well defined in panels
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks: 690166
 
 
Reported: 2012-05-23 16:35 UTC by William Jon McCann
Modified: 2013-02-18 18:03 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
shell: define a style class for the notebook and remove the shadow (1.75 KB, patch)
2013-02-08 11:49 UTC, Thomas Wood
none Details | Review

Description William Jon McCann 2012-05-23 16:35:17 UTC
In a panel the toolbar isn't visually distinct from the rest of the panel.
Comment 1 Allan Day 2012-12-07 14:43:15 UTC
Yes, something needs to be done here. Right now the grid button looks like it is part of the panels rather than belonging to the g-c-c shell.

There have been a few attempts to come up with a visual treatment for this bug, including a simple line along the bottom edge of the toolbar [1], potentially in combination with a different background color for the panels [2].

I'd be happy with the former approach, provided that it doesn't look too heavy.

[1] https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/date-and-time/date-and-time-hi-res.png
[2] https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/power/power-hi-res.png
Comment 2 Bastien Nocera 2012-12-18 15:06:55 UTC
This is a theming problem IMO. We already use a GtkToolBar here.
Comment 3 Matthias Clasen 2013-01-25 19:06:36 UTC
Also see bug 692174
Comment 4 Thomas Wood 2013-02-08 11:49:38 UTC
Created attachment 235502 [details] [review]
shell: define a style class for the notebook and remove the shadow

Define a style class for the notebook and remove the shadow to allow the
border to be set from the theme.
Comment 5 Thomas Wood 2013-02-08 11:51:48 UTC
Review of attachment 235502 [details] [review]:

This patch defines a style class for the widget below the toolbar, as implemented in other applications that have a visual separator between the toolbar and the application content. The styling would still need to be added to the theme after this patch is applied.
Comment 6 Cosimo Cecchi 2013-02-18 18:03:45 UTC
This is fixed in master, since CC now uses a GdHeaderBar and the theme gained a styling for that similar to the mockups mentioned in this report.