GNOME Bugzilla – Bug 676242
[metabug] Verify that elements handle seqnum for seeks correctly
Last modified: 2013-07-25 18:28:57 UTC
Verify that elements involved in seek handling properly set seqnum to the events that they push when performing a seek (flushes and newsegments).
Created attachment 214395 [details] [review] matroskademux: properly handle seqnums of events related to a seek Events that are consequence of a seek event should have the same seqnum as the seek event. This patch fixes the seqnum handling for seeks for matroska demux, I have similar patches for qtdemux, asfdemux, avidemux and I'm still fixing others, the idea of the patch is the same for all of them: store the seqnum of the seek event and set flushes and newsegments to use the same seqnum. In push mode, keep the converted event that goes upstream with the same seqnum of the received seek. If this patch is ok, the others should be, too. So I'll push all them together.
Comment on attachment 214395 [details] [review] matroskademux: properly handle seqnums of events related to a seek Please rebase against latest git master. Also *all* events and messages following a seek should have the seek sequence number. (And remove the "newsegment" notion there, no newsegment event in 1.0 :) )
commit aa5ea6d80e21a3876d81878c0837a28f8842252c Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Thu Jul 25 12:20:14 2013 -0300 baseparse: fix seqnum handling for seeks commit 7eac4c7c030568b99540082f52ec4cf2f35f003d Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Thu Jul 25 11:13:01 2013 -0300 avidemux: fix seqnum handling for seeks commit 8bd12e12b38eab3496955265e38c031db39d262a Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Thu Jul 25 01:39:58 2013 -0300 matroskademux: fix seqnum handling for seeks commit e49b6e7c353dbe366add0e19c20692cff6343b38 Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Thu Jul 25 01:11:31 2013 -0300 qtdemux: correctly handle seqnum for seeks and segments commit c2eb7118beb6d2eb456f275ef7b597855c721e1b Author: Thiago Santos <thiago.sousa.santos@collabora.com> Date: Thu Jul 25 11:28:54 2013 -0300 asfdemux: fix seqnum handling for seeks oggdemux was already ok.