After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672092 - Make thumbnailing in file open dialog smarter
Make thumbnailing in file open dialog smarter
Status: RESOLVED OBSOLETE
Product: eog
Classification: Core
Component: general
git master
Other All
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-14 20:03 UTC by Felix Riemann
Modified: 2021-06-19 08:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Felix Riemann 2012-03-14 20:03:43 UTC
This is a follow up to bug #671944, where the file open dialog had issues with previewing non-thumbnailed images. The original issue was fixed but some other non-critical issues were not addressed:

1) If no thumbnail exists the dialog only previews images smaller than 100KB. This was a good limit a few years ago, but should likely be increased considering that todays digital camera's shoot pictures several MBs large.
For reference: GIMP's file open dialog thumbnails an image in the 2MB range near instantly on my system.

2) If no thumbnail is shown the preview bar is hidden. This makes the file list resize which is a bit distracting if unpreviewable images are mixed with previewable images.


In my opinion GIMP's file open dialog shows pretty nicely how these could be solved. eog's dialog could auto-thumbnail images up to a certain limit (2-3 Megs, more?) and show a placeholder image for larger images. Clicking the placeholder will then trigger the thumbnailing process. This could also be used to have a user-triggered thumbnail update.


+++ This bug was initially created as a clone of Bug #671944 +++

Current policy is not sufficient in handling files with not yet generated thumbnails. Even simple screenshot of my desktop is PNG file with size smaller than 100KB but of large resolution 1440x900. Therefore when I click it preview is generated and it is much too large.

I see two possible solutions. First is too query loaded pixbuf for its dimensions and then judge if preview should be generated. Second is to enforce generating thumbnails for files which don't have yet. I suppose that the second solution is bad choice since it affects users precious time so I implemented draft of the first.

Basically, what is left is choosing arbitrary size of thumbnails or let it be customized (I prefer the first).
Comment 1 André Klapper 2021-06-19 08:47:53 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/eog/-/issues/

Thank you for your understanding and your help.