After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671425 - Avoid adding tags on translation strings
Avoid adding tags on translation strings
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: I18N
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-05 23:55 UTC by Gil Forcada
Modified: 2017-08-07 13:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Reduce use of markup in translatable strings (4.69 KB, patch)
2017-08-06 22:53 UTC, Michael Catanzaro
committed Details | Review
Remove last use of markup in translatable string (1.61 KB, patch)
2017-08-07 13:55 UTC, Michael Catanzaro
committed Details | Review

Description Gil Forcada 2012-03-05 23:55:45 UTC
(sorry me again) I was reviewing my translation and found out some strings which are wrapped between "<b>...</b>" or "<small>...</small>".


See [1] on how to handle this.

Again, and sorry for not starting this translation before the string freeze, remember that we already are on string freeze now :)


[1] https://live.gnome.org/TranslationProject/DevGuidelines/Avoid%20markup%20wherever%20possible
Comment 1 Piotr Drąg 2017-08-02 14:53:25 UTC
This is actually a GNOME Goal: https://wiki.gnome.org/Initiatives/GnomeGoals/RemoveMarkupInMessages
Comment 2 Michael Catanzaro 2017-08-02 21:32:06 UTC
Do any such strings still exist? I try to be careful to ensure markup does not enter translatable strings.
Comment 3 Piotr Drąg 2017-08-02 21:36:50 UTC
#: embed/ephy-about-handler.c:578
msgid ""
"You are currently browsing <em>incognito</em>. Pages viewed in this mode "
"will not show up in your browsing history and all stored information will be "
"cleared when you close the window. Files you download will be kept."
msgstr ""

#. Translators: Notification policy for a specific site.
#: embed/ephy-web-view.c:1405
#, c-format
msgid "The page at <b>%s</b> wants to show desktop notifications."
msgstr ""

#. Translators: Geolocation policy for a specific site.
#: embed/ephy-web-view.c:1410
#, c-format
msgid "The page at <b>%s</b> wants to know your location."
msgstr ""

#. Translators: Microphone policy for a specific site.
#: embed/ephy-web-view.c:1415
#, c-format
msgid "The page at <b>%s</b> wants to use your microphone."
msgstr ""

#. Translators: Webcam policy for a specific site.
#: embed/ephy-web-view.c:1420
#, c-format
msgid "The page at <b>%s</b> wants to use your webcam."
msgstr ""

#. Refers to "Only from sites you visit" option under Cookies.
#: src/resources/gtk/prefs-dialog.ui:525
msgid "<small>For example, not from advertisers on these sites</small>"
msgstr ""



The first one is pretty tricky, but the rest are relatively straightforward to fix.
Comment 4 Michael Catanzaro 2017-08-06 22:50:24 UTC
The first one is actually easy, because we shouldn't be italicizing the word incognito there anyway!

How would you fix the last one? It is tricky because it is in a UI file and we can't programatically add the markup there. I've fixed the other cases.
Comment 5 Michael Catanzaro 2017-08-06 22:53:20 UTC
The following fix has been pushed:
6f489f3 Reduce use of markup in translatable strings
Comment 6 Michael Catanzaro 2017-08-06 22:53:23 UTC
Created attachment 357076 [details] [review]
Reduce use of markup in translatable strings
Comment 7 Piotr Drąg 2017-08-07 00:53:32 UTC
Great work, thank you!

For the last one, I’ve seen <attribute name="scale" value="0.8"/> in the wild.
Comment 8 Michael Catanzaro 2017-08-07 13:55:30 UTC
The following fix has been pushed:
a0accbf Remove last use of markup in translatable string
Comment 9 Michael Catanzaro 2017-08-07 13:55:33 UTC
Created attachment 357113 [details] [review]
Remove last use of markup in translatable string