GNOME Bugzilla – Bug 671301
l10n: need comments/contexts
Last modified: 2012-03-21 17:05:08 UTC
#: ../pgp/seahorse-add-uid.xml.h:5 ../pgp/seahorse-pgp-generate.xml.h:5 msgid "Full _Name:" msgstr "" #: ../pgp/seahorse-pgp-key-properties.c:535 #: ../pgp/seahorse-pgp-key-properties.c:1846 msgid "Name/Email" msgstr "" #: ../pgp/seahorse-pgp-private-key-properties.xml.h:31 msgid "_Add Name" msgstr "" #: ../pgp/seahorse-pgp-private-key-properties.xml.h:33 msgid "Names and Signatures" msgstr "" #: ../pgp/seahorse-pgp-public-key-properties.xml.h:20 msgid "<b>_Other Names:</b>" msgstr "" It's not clear whether it's a person name or a key name. #: ../pgp/seahorse-keyserver-results.c:243 ../src/seahorse-key-manager.c:517 msgid "_Remote" msgstr "" Remote *what*? In some languages, there is a rich gender system where the form of translations for such messages will differ depending on what is assumed. #: ../pgp/seahorse-pgp-key-properties.c:428 #: ../pgp/seahorse-pgp-key-properties.c:1564 msgid "[Unknown]" msgstr "" #: ../pgp/seahorse-pgp-key-properties.c:906 msgid "(unknown)" msgstr "" Same. #: ../pgp/seahorse-pgp-generate.xml.h:1 msgid "Algorithms here" msgstr "" What does 'here' mean here? Isn't it the same as just 'Algorithms'? #: ../pgp/seahorse-pgp-private-key-properties.xml.h:15 #: ../pgp/seahorse-pgp-public-key-properties.xml.h:10 msgid "<b>Photo </b>" msgstr "" #: ../pgp/seahorse-pgp-public-key-properties.xml.h:13 msgid "Encrypt files and email to the key's owner " msgstr "" Is the trailing space intended? If not, just remove it. If yes, then please stop splitting messages into several translation units because it doesn't work smoothly for some languages. See: https://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences #: ../pgp/seahorse-sign.xml.h:9 msgid "" "<i>Casually:</i> means you have done a casual verification that the key is " "owned by the person who claims to own it. For example, you could read the " "key fingerprint to the owner over the phone. " msgstr "" I suppose trailing space is unneeded. #: ../ssh/seahorse-ssh-deleter.c:91 ../ssh/seahorse-ssh-deleter.c:92 #, c-format msgid "Are you sure you want to delete %d secure shell keys?" msgstr "" We need plural forms for this. See: https://live.gnome.org/TranslationProject/DevGuidelines/Plurals #: ../ssh/seahorse-ssh-key-properties.xml.h:13 #, no-c-format msgid "<i>This only applies to the '%s'</i> account." msgstr "" Is such tagging really intended? If so, what are you trying to communicate to the user with it? It's not clear for translator.
Thanks for catching these problems. > #: ../pgp/seahorse-pgp-public-key-properties.xml.h:20 > msgid "<b>_Other Names:</b>" > msgstr "" > > It's not clear whether it's a person name or a key name. Usually it's both. That's the reality. People use their personal name as the name of their key. > #: ../pgp/seahorse-keyserver-results.c:243 ../src/seahorse-key-manager.c:517 > msgid "_Remote" > msgstr "" > > Remote *what*? In some languages, there is a rich gender system where the form > of translations for such messages will differ depending on what is assumed. Remote systems. > #: ../ssh/seahorse-ssh-key-properties.xml.h:13 > #, no-c-format > msgid "<i>This only applies to the '%s'</i> account." > msgstr "" > > Is such tagging really intended? If so, what are you trying to communicate to > the user with it? It's not clear for translator. Looks like a bug. Fixed the message. Fixed in git master: commit da5207d9ac11b2489676924625f590743329b4ee Author: Stef Walter <stefw@gnome.org> Date: Fri Mar 9 18:56:33 2012 +0100 Fix translatable messages https://bugzilla.gnome.org/show_bug.cgi?id=671301 If you'd rather that the fixes were done differently, then please provide a patch with your changes.
Plural forms are still done incorrectly: #. This is never used for singular, but need ngettext to keep translators happy #: ../ssh/seahorse-ssh-deleter.c:92 #, c-format msgid "Are you sure you want to delete %d secure shell key?" msgstr "" #: ../ssh/seahorse-ssh-deleter.c:93 #, c-format msgid "Are you sure you want to delete %d secure shell keys?" msgstr "" Firstly, we still have no proper support for languages with more than 2 plural forms. Secondly, the statement in the comment insists that first form is to be used for exactly 1 object only. But it's not valid for lots of languages. In mine, we have the same form for 1, 11, 21, ... So it's not just to make translators happy, it's for real use cases. The idea and solutions for plural issues are explained here: https://live.gnome.org/TranslationProject/DevGuidelines/Plurals
Removed the comment in master. If still not correct, please provide a patch to correct the issue. commit cca3069d7c137b30c20b122c5618e0da6f4c1cb2 Author: Stef Walter <stefw@gnome.org> Date: Wed Mar 14 22:08:31 2012 +0100 Remove translator comment, since string is used for certain forms http://bugzilla.gnome.org/show_bug.cgi?id=671301
#: ../ssh/seahorse-ssh-deleter.c:91 ../ssh/seahorse-ssh-deleter.c:92 #, c-format msgid "Are you sure you want to delete %d secure shell keys?" msgstr "" Still not plural-aware...
(In reply to comment #3) > If still not correct, please provide a patch to > correct the issue. ^^ Thanks
Do you really mean localizers should fix coding issues?
Yes, everyone contributes to open source. But more to the point: Nobody could give me a straight answer on what was wrong. Just that it was wrong. Therefore I could not fix it. Even reading the documentation didn't help me figure it out. In any case someone else very helpfully pointed out what needed to be fixed on the gnome-i18n mailing list.
I don't know who pointed into which, but the problem is still in place. See: http://l10n.gnome.org/POT/seahorse.gnome-3-4/seahorse.gnome-3-4.be.po #: ../ssh/seahorse-ssh-deleter.c:91 ../ssh/seahorse-ssh-deleter.c:92 #, c-format msgid "Are you sure you want to delete %d secure shell keys?" msgstr "Сапраўды выдаліць %d ключоў SSH?" The problem is that you don't use plural gettext functions for this message (see man 3 ngettext). And they are described for developers in the link I already posted above, with rationale for their usage. See: https://live.gnome.org/TranslationProject/DevGuidelines/Plurals It's worth reading! It's not about me unable to checkout git, and patch seahorse code, and test the code, and send the patch. But this is an overkill for me because I'm a localizer on this project and don't expect so much work for simple fix to be pushed into repository. I don't have a build system ready for seahorse compilation on my system, so this will require ~ half a day to get this issue fixed. Could you please elaborate instead?
Hi, now I see the needed fix in gnome-3-4. Thanks!
Yes, it had been merged to master, after a helpful pointer on gnome-i18n from Abderrahim. I got clearance to merge it into gnome-3-4 today. The problem was not the lack of ngettext, but using ngettext() and _() together.