GNOME Bugzilla – Bug 668948
gconf_engine_key_is_writable missing in dbus variant
Last modified: 2018-08-17 13:59:52 UTC
Hi, It seems that gconf_engine_key_is_writable() is not present when gconf is compiled with dbus code. This is an ABI break and the function should be added back. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649112
Not sure why it's not there, but I guess a fix would imply using gconf_engine_get_fuller() or gconf_engine_get_full() to get if the key is writable.
Missing by omission more than design, the fork was so long-lived that we must have missed a function in the diff.
Any hope we can get this fixed in next release?
Created attachment 208121 [details] [review] gconf-dbus: Add gconf_engine_key_is_writable() This went missing in the dbus port, and so we broke ABI. It's really the same code as in the corba code.
Created attachment 208123 [details] [review] gconf-dbus: Add gconf_engine_key_is_writable() It's really the same code as in the corba code. I just copied it, and it builds fine. Not tested. Alternatively, we could play with the ifdef/endif in gconf.c, but this might be confusing.
(Woo, attached twice, due to bugzilla not responding) Of course, we should kill the comment about IDL if we choose to just use the patch like this.
could that lead to the g_assert in https://bugzilla.gnome.org/show_bug.cgi?id=670586? the stacktrace indicates gconf_client_key_is_writable() is called, not sure how it's possible if the function is supposed to be missing though...
I doubt it's related, but can't be sure.
Hello, I think this bug can be closed: gconf/gconf-dbus.c:gconf_engine_key_is_writable (GConfEngine *conf, gconf/gconf.c:gconf_engine_key_is_writable (GConfEngine *conf,
GConf has been deprecated since 2011. GConf is not under active development anymore. Its codebase has been archived: https://gitlab.gnome.org/Archive/gconf/commits/master dconf and gsettings are its successors. See https://developer.gnome.org/gio/stable/ch34.html and https://developer.gnome.org/GSettings/ for porting info. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Feel free to open a task in GNOME Gitlab if the issue described in this task still applies to a recent + supported version of dconf/gsettings. Thanks!