After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668380 - [h264parse] [codecparsers] gst_h264_parse_hrd_parameters not reading cbr_flag
[h264parse] [codecparsers] gst_h264_parse_hrd_parameters not reading cbr_flag
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-20 22:57 UTC by Jonas Larsson
Modified: 2012-02-18 19:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that read cbr_flag in gst_h264_parse_hrd_parameters (730 bytes, patch)
2012-01-20 22:57 UTC, Jonas Larsson 		none Details | Review
First few NALs from a stream that is incorrectly parsed (1.77 KB, application/octet-stream)
2012-01-20 23:00 UTC, Jonas Larsson 		  Details

Description Jonas Larsson 2012-01-20 22:57:26 UTC 
Created attachment 205736 [details] [review]
Patch that read cbr_flag in gst_h264_parse_hrd_parameters

gst_h264_parse_hrd_parameters in gst-libs/gst/codecparsers/gsth264parser.c is not reading cbr_flag. This breaks parsing of the rest of vui_parameters, and gst_h264_parse_vui_parameters returns failure. This propagates so the parsing of the entire SPS is deemed as a failure. Basically this renders the parsed stream useless.

The fix is simple, just read one more bit in gst_h264_parse_hrd_parameters. The flag is already declared in GstH264HRDParams.

legacyh264parse read this flag but it seems to be overlooked in the new parser.
Comment 1 Jonas Larsson 2012-01-20 23:00:17 UTC 
Created attachment 205737 [details]
First few NALs from a stream that is incorrectly parsed
Comment 2 Thibault Saunier 2012-01-23 18:02:55 UTC 
commit 657226d9f0ea27f3923c6af89a24911eefc28f88
Author: Jonas Larsson <jonas@hallerud.se>
Date:   Mon Jan 23 18:51:34 2012 +0100

    codecparsers: read the cbr_flag in h264_parse_hrd_parameters