After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667298 - basesink: don't compensate for render-delay twice
basesink: don't compensate for render-delay twice
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal major
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-04 20:03 UTC by Håvard Graff (hgr)
Modified: 2012-01-05 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.54 KB, patch)
2012-01-04 20:03 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2012-01-04 20:03:56 UTC 
Created attachment 204616 [details] [review]
patch

gst_base_sink_adjust_time already subtracts render-delay.
Comment 1 Tim-Philipp Müller 2012-01-05 01:27:34 UTC 
> gst_base_sink_adjust_time already subtracts render-delay.

Because it was included in the measured latency, as I understand it:

  /* subtract the render delay again, which was included in the latency */
  if (time > basesink->priv->render_delay)
    time -= basesink->priv->render_delay;
  else
    time = 0;


A unit test for this would be nice...
Comment 2 Håvard Graff (hgr) 2012-01-05 09:53:28 UTC 
Sure, but in this case it is quite obvious. If you check gst_base_sink_adjust_time, it already subtracts render-delay. (even though the comment says it doesn't...) and then it is subtracted again...
Comment 3 Tim-Philipp Müller 2012-01-05 18:09:10 UTC 
<wtay> the patch is correct

 commit bea0ed2fc1da66f97b38397188e7ffb3a8619e61
 Author: Havard Graff <havard.graff@tandberg.com>
 Date:   Tue Nov 29 14:22:44 2011 +0100

    basesink: don't compensate for render-delay twice
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667298