After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667102 - It Seems All Non Space Characters Are Considered Valid URL Characters
It Seems All Non Space Characters Are Considered Valid URL Characters
Status: RESOLVED FIXED
Product: nfoview
Classification: Other
Component: general
1.10
Other Linux
: Normal minor
: ---
Assigned To: nfoview-maint
nfoview-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-01 20:11 UTC by baskerville
Modified: 2015-05-09 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description baskerville 2012-01-01 20:11:13 UTC
I stumbled upon an NFO where a ░ character (U2591) was immediately following an URL and it was seen as a valid URL character.
Comment 1 Osmo Salomaa 2012-01-01 20:42:54 UTC
This is true. Lines are split to words by spaces and words are considered URLs if they match the following regular expression.

    r"(([0-9a-zA-Z]+://\S+?\.\S+)|(www\.\S+?\.\S+))"

Sometimes, although rarely, there will be errors as the one you have now stumbled on.

I'm open to suggestions on how to fix this problem. Any strict list of characters allowed in URLs by some specification is not enough since most browsers are "smart" and often implicit in converting special characters to their %-escaped equivalents and authors often rely on those conversions being available.
Comment 2 Osmo Salomaa 2015-05-09 20:46:39 UTC
Maybe it's best to provide some kind of a limited list of characters after all, we'll see how it works.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.

commit 0ef94eb8b0d46fedfe5b224ea40df92315d8040a
Author: Osmo Salomaa <otsaloma@iki.fi>
Date:   Sat May 9 23:42:37 2015 +0300

    Improve URL detection.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667102

https://github.com/otsaloma/nfoview/commit/0ef94eb8b0d46fedfe5b224ea40df92315d8040a