After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 665976 - Port to Vala
Port to Vala
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnotski
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-12 01:51 UTC by Robert Ancell
Modified: 2012-11-11 22:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A quick stab at porting this to Vala (83.34 KB, patch)
2011-12-12 01:51 UTC, Robert Ancell 		none Details | Review
Port from C to Vala (80.86 KB, patch)
2011-12-13 02:18 UTC, Robert Ancell 		none Details | Review
Port from C to Vala (84.19 KB, patch)
2011-12-13 09:47 UTC, Robert Ancell 		none Details | Review
Port from C to Vala (87.61 KB, patch)
2011-12-13 10:33 UTC, Robert Ancell 		none Details | Review
Port from C to Vala (84.94 KB, patch)
2011-12-31 07:20 UTC, Robert Ancell 		none Details | Review
Port from C to Vala (83.79 KB, patch)
2012-01-01 07:46 UTC, Robert Ancell 		needs-work Details | Review
vala version of gnome-klotski (234.82 KB, patch)
2012-11-04 12:48 UTC, John Cheetham 		committed Details | Review

Description Robert Ancell 2011-12-12 01:51:45 UTC 
Created attachment 203226 [details] [review]
A quick stab at porting this to Vala

Port to Vala
Comment 1 Robert Ancell 2011-12-13 02:18:45 UTC 
Created attachment 203313 [details] [review]
Port from C to Vala
Comment 2 Robert Ancell 2011-12-13 09:47:19 UTC 
Created attachment 203324 [details] [review]
Port from C to Vala
Comment 3 Robert Ancell 2011-12-13 10:33:31 UTC 
Created attachment 203327 [details] [review]
Port from C to Vala
Comment 4 Robert Ancell 2011-12-17 12:11:00 UTC 
(anyone is welcome to pick this patch up and finish it if they want)
Comment 5 Robert Ancell 2011-12-31 07:20:09 UTC 
Created attachment 204370 [details] [review]
Port from C to Vala
Comment 6 Robert Ancell 2012-01-01 07:46:39 UTC 
Created attachment 204408 [details] [review]
Port from C to Vala
Comment 7 John Cheetham 2012-11-01 19:24:32 UTC 
I am looking at updating this patch. I will remove the libgames-support stuff, add gtk.application, remove status bar and move the messages to a new tool bar.

I made some progress but it's not finished yet (I am new to vala/gtk3). Hopefully I will post a new patch (for the new split-off gnome-klotski repo) in a couple of days.
Comment 8 Thomas Andersen 2012-11-01 22:02:19 UTC 
Hi John,

That sounds really great. It would be very much appreciated.
Comment 9 John Cheetham 2012-11-04 12:48:38 UTC 
Created attachment 228019 [details] [review]
vala version of gnome-klotski
Comment 10 Thomas Andersen 2012-11-05 10:14:02 UTC 
From a quick glance this looks really good. I am assuming that the patch is tested so I plan to commit this tonight!

Just a few comments:
Do we still need the gmodule? (in src/Makefile.am) It should not be necessary with the glib actionentry. I also see no direct use of pango.

There is also some commented out code about a game clock? That does not belong in this game right?
Comment 11 John Cheetham 2012-11-05 18:46:52 UTC 
It should be OK to commit it.

I tried removing the gmodule and pango from src/Makefile.am and it still works so as you say it's not needed. Same goes for the clock code which I think is part of some toolbar code I copied from tetravex. Tetravex displays a clock and klotski doesn't so I should have deleted that.
Comment 12 Thomas Andersen 2012-11-05 19:59:24 UTC 
Comment on attachment 228019 [details] [review]
vala version of gnome-klotski

Committed to master:http://git.gnome.org/browse/gnome-klotski/commit/?id=bb374fb52e35dca6ff7f8b1e16543b149b888f49

Thanks John and Robert
Comment 13 Robert Ancell 2012-11-11 22:52:56 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.