After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664970 - Use GtkApplication
Use GtkApplication
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks: 664963
 
 
Reported: 2011-11-27 22:57 UTC by Robert Ancell
Modified: 2014-05-30 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for this (and another) bug. (33.69 KB, patch)
2012-04-06 12:06 UTC, Chris Baines 		needs-work Details | Review

Description Robert Ancell 2011-11-27 22:57:44 UTC 
Use GtkApplication
Comment 1 Chris Baines 2012-04-06 12:06:40 UTC 
Created attachment 211466 [details] [review]
Patch for this (and another) bug.

This patch uses the GtkApplication feature, and also introduces the GMenu feature which depends on this.
Comment 2 Robert Ancell 2012-05-28 23:21:26 UTC 
Review of attachment 211466 [details] [review]:

Sorry, I missed this patch.  (Feel free to add comments to the bug, i.e. "why haven't you reviewed my patch!").

It doesn't apply now, can you update it?

Also, in general it is both easier to review and makes it easier to track changes (e.g. looking for regressions) if you just add one feature at a time, i.e. have a GtkApplication patch and a GMenu patch.

Apart from that it is good to go.
Comment 3 Thomas Andersen 2012-05-29 06:57:03 UTC 
We already landed parts of the patch to the sudoku-vala branch. The rest is wip while Chris is finishing his exams.