After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664955 - Remove statusbar
Remove statusbar
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: iagno
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-27 22:49 UTC by Robert Ancell
Modified: 2012-02-04 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
iagno: add toolbar with GtkBuilder (5.06 KB, patch)
2012-01-07 01:23 UTC, Tiffany Antopolski
needs-work Details | Review
iagno: removal of statusbar (1.53 KB, patch)
2012-01-07 04:17 UTC, Tiffany Antopolski
none Details | Review
iagno: set hexpand and vexpand to true on the GameView. (905 bytes, patch)
2012-01-13 06:44 UTC, Tiffany Antopolski
accepted-commit_now Details | Review
iagno.vala: fixed spacing issue caused by last commit (908 bytes, patch)
2012-01-13 06:58 UTC, Tiffany Antopolski
none Details | Review
collapsing previous 4 patches into one. (5.95 KB, patch)
2012-01-13 07:26 UTC, Tiffany Antopolski
none Details | Review
catch exception from bulder.add_from_file (6.12 KB, patch)
2012-01-13 09:07 UTC, Tiffany Antopolski
none Details | Review
iagno: add toolbar (GtkBuilder) and remove statusbar (6.82 KB, patch)
2012-01-21 01:54 UTC, Tiffany Antopolski
needs-work Details | Review
iagno: add toolbar (GtkBuilder) and remove statusbar (17.27 KB, patch)
2012-01-21 18:24 UTC, Tiffany Antopolski
committed Details | Review

Description Robert Ancell 2011-11-27 22:49:54 UTC
Remove statusbar.  Move any remaining content (e.g. the clock) into the toolbar or into the game view.
Comment 1 Tiffany Antopolski 2012-01-06 01:06:24 UTC
I'll give this a try.
Comment 2 Tiffany Antopolski 2012-01-07 01:23:27 UTC
Created attachment 204793 [details] [review]
iagno: add toolbar with GtkBuilder

I thought I would first add a toolbar.
Comment 3 Tiffany Antopolski 2012-01-07 04:17:40 UTC
Created attachment 204796 [details] [review]
iagno: removal of statusbar

Moved content to the toolbar.

The content is not properly aligned though, and I can't figure out why.
Comment 4 Robert Ancell 2012-01-09 06:54:12 UTC
Review of attachment 204793 [details] [review]:

Thanks Tiffany!

Needs the following fixes:
- You should catch the exception from builder.add_from_file and print it to stderr and exit with a failure code
- You need to set hexpand and vexpand to true on GameView so it takes up the available space
- The signals on the new and undo buttons need to be connected up
Comment 5 Tiffany Antopolski 2012-01-13 06:44:24 UTC
Created attachment 205162 [details] [review]
iagno: set hexpand and vexpand to true on the GameView.

This makes it so the view takes up the available space.
Comment 6 Robert Ancell 2012-01-13 06:51:11 UTC
Review of attachment 205162 [details] [review]:

Looks fine, but replace the tab characters with four spaces!
Comment 7 Tiffany Antopolski 2012-01-13 06:58:45 UTC
Created attachment 205163 [details] [review]
iagno.vala: fixed spacing issue caused by last commit
Comment 8 Tiffany Antopolski 2012-01-13 07:26:47 UTC
Created attachment 205164 [details] [review]
collapsing previous 4 patches into one.
Comment 9 Tiffany Antopolski 2012-01-13 09:07:04 UTC
Created attachment 205168 [details] [review]
catch exception from bulder.add_from_file

This patch takes care of catching the exception from bulder.add_from_file and setting the hexpand and vexpand to true on the GameView (as suggested above).  I am thinking of removing the new and undo buttons from the toolbar.  Tetravex only has the statusbar items the toolbar, so I think this will be more consistent.  I haven't removed them yet.  They were added using glade, and attempting to remove them has proven to be tricky thus far.  Stay tuned...
Comment 10 Tiffany Antopolski 2012-01-13 10:29:11 UTC
I just learned that the only reason Tetravex doesn't have other items in the toolbar is due to a limitation in gtk.  Therefore I will connect the signals shortly.
Comment 11 Tiffany Antopolski 2012-01-21 01:54:37 UTC
Created attachment 205740 [details] [review]
iagno: add toolbar (GtkBuilder) and remove statusbar

Contents of statusbar moved into the toolbar.


Okay, all done.  Signals (actions) are now hooked up.
However, the statusbar items which are now in the
toolbar are still not lined up properly.  I don't have 
the solution for this problem.
Comment 12 Robert Ancell 2012-01-21 07:23:34 UTC
Review of attachment 205740 [details] [review]:

bob@alchemy:~/git/gnome-games/iagno$ make
Making all in src
make[1]: Entering directory `/home/bob/git/gnome-games/iagno/src'
  VALAC  iagno_vala.stamp
iagno.vala:47.5-51.6: error: `GLib.ActionEntry[]' not supported as type for constants
iagno.vala:110.9-110.26: error: The name `add_action_entries' does not exist in the context of `Iagno.activate'
        add_action_entries (app_actions, this);
        ^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)

Does this need a certain version of GLib/Vala?
Comment 13 Tiffany Antopolski 2012-01-21 16:07:56 UTC
new Gtk and new Glib.
Comment 14 Tiffany Antopolski 2012-01-21 16:27:56 UTC
I Robert,

Actually, it's a new vala (as I just read the error more carefully.)

T.
Comment 15 Tiffany Antopolski 2012-01-21 18:24:18 UTC
Created attachment 205771 [details] [review]
iagno: add toolbar (GtkBuilder) and remove statusbar

Contents of statusbar moved into the toolbar.





This should work with the  old Vala.
Comment 16 Robert Ancell 2012-02-04 11:45:48 UTC
Review of attachment 205771 [details] [review]:

Pushed.  There's some minor alignment issues in the bar and I think it needs to be marked as a "primary toolbar" or similar to get the right theming (see other games how they do that).  Improvement over what is there though so pushed.