After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664942 - Port to Vala
Port to Vala
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: iagno
trunk
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-27 22:28 UTC by Robert Ancell
Modified: 2011-12-29 04:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Very rough start at porting (41.38 KB, patch)
2011-12-22 07:28 UTC, Robert Ancell
none Details | Review
Very rough start at porting (58.50 KB, patch)
2011-12-22 10:55 UTC, Robert Ancell
none Details | Review
Rough start at porting (56.80 KB, patch)
2011-12-23 01:37 UTC, Robert Ancell
none Details | Review
Almost compiles... (58.62 KB, patch)
2011-12-23 04:19 UTC, Robert Ancell
none Details | Review
Compiles! (59.12 KB, patch)
2011-12-23 09:02 UTC, Robert Ancell
none Details | Review
Working port, pre refactoring (59.72 KB, patch)
2011-12-24 09:04 UTC, Robert Ancell
none Details | Review
Working port with some refactoring (58.01 KB, patch)
2011-12-24 10:35 UTC, Robert Ancell
none Details | Review
Almost there after some heavy refactoring (44.84 KB, patch)
2011-12-27 07:26 UTC, Robert Ancell
none Details | Review
Port from C to Vala (48.44 KB, patch)
2011-12-29 04:00 UTC, Robert Ancell
committed Details | Review

Description Robert Ancell 2011-11-27 22:28:57 UTC
Port to Vala
Comment 1 Robert Ancell 2011-11-27 22:37:35 UTC
It may be worth looking at bug 585659 which was another rewrite in C and may contain useful improvements.
Comment 2 Robert Ancell 2011-12-22 07:28:09 UTC
Created attachment 204071 [details] [review]
Very rough start at porting
Comment 3 Robert Ancell 2011-12-22 10:55:04 UTC
Created attachment 204079 [details] [review]
Very rough start at porting
Comment 4 Robert Ancell 2011-12-23 01:37:49 UTC
Created attachment 204125 [details] [review]
Rough start at porting
Comment 5 Robert Ancell 2011-12-23 04:19:09 UTC
Created attachment 204126 [details] [review]
Almost compiles...
Comment 6 Robert Ancell 2011-12-23 09:02:52 UTC
Created attachment 204130 [details] [review]
Compiles!
Comment 7 Robert Ancell 2011-12-24 09:04:52 UTC
Created attachment 204168 [details] [review]
Working port, pre refactoring
Comment 8 Robert Ancell 2011-12-24 10:35:00 UTC
Created attachment 204170 [details] [review]
Working port with some refactoring
Comment 9 Robert Ancell 2011-12-27 07:26:26 UTC
Created attachment 204256 [details] [review]
Almost there after some heavy refactoring
Comment 10 Robert Ancell 2011-12-29 04:00:15 UTC
Created attachment 204308 [details] [review]
Port from C to Vala

Final patch applied to master.  Some options that didn't seem to work or were obsolete have been removed.
Comment 11 Robert Ancell 2011-12-29 04:00:39 UTC
Review of attachment 204308 [details] [review]:

applied to master