After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 664892 - [matroskademux] Doesn't set caps properly
[matroskademux] Doesn't set caps properly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-26 23:43 UTC by Tim-Philipp Müller
Modified: 2011-12-01 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2011-11-26 23:43:37 UTC
Consider the following clip:

http://samples.mplayerhq.hu/Matroska/matrix/Matrix.Reloaded.Trailer-640x346-XviD-1.0beta2-HE_AAC_subtitled.mkv

It should start up with Arabic subtitles. Switch to French and do a short seek back (to flush).

Expected result: from now on we should see French subs to go with the text:

Actual result: the french text is prefixed by subtitle format junk (looks like SSA/ASS formatting).

The arabic subs seem to be pango markup while the others are application/x-ssa, so it looks like something goes wrong with the parser switching or routing.
Comment 1 Sebastian Dröge (slomo) 2011-11-27 12:40:06 UTC
Is this a regression? I can't remember any changes in subtitleoverlay that are related to this and the only changes I remember are the ones by Josep to add support for non-raw renderers.
Comment 2 Tim-Philipp Müller 2011-11-27 13:03:16 UTC
It seems to work fine with the 0.10.35 packages in sid.
Comment 3 Sebastian Dröge (slomo) 2011-12-01 10:39:06 UTC
Arabic is text/plain and French is SSA/ASS but subtitleoverlay doesn't get the new caps for some reason.
Comment 4 Sebastian Dröge (slomo) 2011-12-01 11:20:25 UTC
This is a core blocker, the subtitle sinkpad of subtitleoverlay never has any caps set.
Comment 5 Sebastian Dröge (slomo) 2011-12-01 11:29:23 UTC
Actually a bug in matroskademux
Comment 6 Sebastian Dröge (slomo) 2011-12-01 11:49:05 UTC
commit 6d4a634626d6934a670496a2c35b181ea896ad78
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Thu Dec 1 12:47:26 2011 +0100

    matroskademux: Copy all buffer flags when creating a subtitle buffer copy after postprocessing
    
    This also copies the caps. Otherwise we could end up pusing
    the first buffer without any caps, which causes downstream
    to not get notified about the caps.
    
    Fixes bug #664892.