GNOME Bugzilla – Bug 664140
Add new effect: SVG Image Overlay
Last modified: 2021-07-05 12:26:33 UTC
Display an SVG image (that does not move) over the video.
Created attachment 201482 [details] [review] Adds 7 SVG sample files and the needed files to generate the new .effect file on install This patch includes work and corrections made by Daniel Siegel, thanks Daniel! To show a different image, edit the svgoverlay.effect file, usually found in /usr/share/gnome-video-effects Sample SVG files are provided, found in /usr/share/gnome-video-effects/overlays
Created attachment 201483 [details] [review] Additional sample SVG image Additional SVG sample image, apply this patch after the first one.
Review of attachment 201482 [details] [review]: It seems that although several overlay images are installed, there is only one effect file, so in Cheese only one overlay effect will be shown. Should effect files be generated for the other overlay images, so that they can also be used, or is there a better way of changing the image that is shown in the overlay?
at some point there was the idea to have configurable effect files, see #626533. as it somehow lacks of motivation, i guess it is up to you ;)
Created attachment 206459 [details] [review] updated rsvgoverlay patch 1/3 I updated the patches to current master, and added .effect files for the additional images. I tried the overlays on an Atom tablet, but I could only get a framerate of about 1 frame every 10 seconds! This is far too slow to merge the overlay patches at the moment. Laura, is it expected that the performance of rsvgoverlay is this bad?
Created attachment 206461 [details] [review] updated rsvgoverlay patch 2/3
Created attachment 206462 [details] [review] updated rsvgoverlay patch 3/3
> the overlay patches at the moment. Laura, is it expected that the performance > of rsvgoverlay is this bad? No, it's not expected, but I saw problems in performance with some of the svg overlays provided, while others worked faster, for example compare frame_kiss.svg with frame_wanted.svg, the latter has performance problems. So, to a certain point it depends on the svg file. But I've seen acceptable frame rates with the simpler svg files. I would include only one effect to be displayed in the effects selector, because when displaying several previews at the same time with svg overlays, the problem worsens (please confirm this, I'm not testing at the moment, just telling what I remember, my theory is that the svg file is redrawn every frame). Then it would depend on the user to change the svg image, maybe add a simple entry in a right-click contextual menu over the effect preview that simply opens the .effect file in gedit?
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-video-effects/-/issues/ Thank you for your understanding and your help.