GNOME Bugzilla – Bug 66334
[PATCH] gnome-info2html2 can't handle *.bz2
Last modified: 2010-04-29 22:38:28 UTC
because 1. bzread() and gzgets() is non-compatibility. 2. The treatment of bzip occurs halfway.... result=read_node( f, line, node ); "f" must be "bf" the time of using bzip2.
Created attachment 6166 [details] [review] very dirty patch
Thanks. Moving to libgnome (help converters have been moved there for GNOME 2).
andersca, jfleck: I'm not entirely sure how much code from libgnome is still relevant for GNOME2. We're now down to 14 bugs here, so if you could check these and remove the GNOME2 keyword if they /aren't/ relevant anymore, it would be appreciated. Filter on 'luis doing GNOME2 work' if you want to ignore these.
I'm not qualified to comment on this one.
I'll try to look at it for 2.0
Looking at this I see that we need to change more than just this. I also don't like the idea of creating temporary files when the problem can be solved in a better (but much trickier way). I don't think we can get this done in time for 2.0.
Created attachment 7955 [details] [review] better bzip2 support
Here is a cleaner version (with abstraction of read to deal correctly with bzip2 and gzip files).. Ok to commit ?
Definitely not a blocker.
Created attachment 8122 [details] [review] Revised version of bzip2 patch
fcrozat: are you going to commit this?
Committed in CVS