After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 66334 - [PATCH] gnome-info2html2 can't handle *.bz2
[PATCH] gnome-info2html2 can't handle *.bz2
Status: RESOLVED FIXED
Product: yelp
Classification: Applications
Component: XSLT
2.3.x
Other other
: High minor
: ---
Assigned To: Mikael Hallendal
Yelp maintainers
Depends on:
Blocks:
 
 
Reported: 2001-12-06 07:46 UTC by Shingo Akagaki
Modified: 2010-04-29 22:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
very dirty patch (2.52 KB, patch)
2001-12-06 07:47 UTC, Shingo Akagaki
none Details | Review
better bzip2 support (10.86 KB, patch)
2002-04-25 17:05 UTC, Frederic Crozat
none Details | Review
Revised version of bzip2 patch (8.99 KB, patch)
2002-05-02 16:44 UTC, Frederic Crozat
none Details | Review

Description Shingo Akagaki 2001-12-06 07:46:26 UTC
because

1. bzread() and gzgets() is non-compatibility.
2. The treatment of bzip occurs halfway....
 
            result=read_node( f, line, node );

"f" must be "bf" the time of using bzip2.
Comment 1 Shingo Akagaki 2001-12-06 07:47:52 UTC
Created attachment 6166 [details] [review]
very dirty patch
Comment 2 John Fleck 2001-12-06 14:27:33 UTC
Thanks.
Moving to libgnome (help converters have been moved there for GNOME 2).
Comment 3 Luis Villa 2002-01-28 23:37:15 UTC
andersca, jfleck: I'm not entirely sure how much code from libgnome is still
relevant for GNOME2. We're now down to 14 bugs here, so if you could check these
and remove the GNOME2 keyword if they /aren't/ relevant anymore, it would be
appreciated. Filter on 'luis doing GNOME2 work' if you want to ignore these.
Comment 4 John Fleck 2002-01-29 01:50:28 UTC
I'm not qualified to comment on this one.
Comment 5 Anders Carlsson 2002-02-11 02:40:16 UTC
I'll try to look at it for 2.0
Comment 6 Anders Carlsson 2002-04-08 10:43:25 UTC
Looking at this I see that we need to change more than just this. I
also don't like the idea of creating temporary files when the problem
can be solved in a better (but much trickier way).

I don't think we can get this done in time for 2.0.

Comment 7 Frederic Crozat 2002-04-25 17:05:19 UTC
Created attachment 7955 [details] [review]
better bzip2 support
Comment 8 Frederic Crozat 2002-04-25 17:06:13 UTC
Here is a cleaner version (with abstraction of read to deal correctly
with bzip2 and gzip files).. Ok to commit ?
Comment 9 Luis Villa 2002-05-01 09:29:35 UTC
Definitely not a blocker.
Comment 10 Frederic Crozat 2002-05-02 16:44:00 UTC
Created attachment 8122 [details] [review]
Revised version of bzip2 patch
Comment 11 Luis Villa 2002-05-14 03:23:53 UTC
fcrozat: are you going to commit this?
Comment 12 Frederic Crozat 2002-05-14 10:12:01 UTC
Committed in CVS