After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663312 - decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values
decodebin2: Post all source pads in stream-topology messages as "element-srcp...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other Linux
: Normal enhancement
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-11-03 12:33 UTC by Mart Raudsepp
Modified: 2011-11-03 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
decodebin2: Use existing "caps" quark for one of the structure sets (811 bytes, patch)
2011-11-03 12:34 UTC, Mart Raudsepp
committed Details | Review
decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values (3.78 KB, patch)
2011-11-03 12:35 UTC, Mart Raudsepp
needs-work Details | Review
decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values (3.79 KB, patch)
2011-11-03 13:29 UTC, Mart Raudsepp
committed Details | Review

Description Mart Raudsepp 2011-11-03 12:33:41 UTC
This allows us to easily get ahold of all pads on a stream-topology message, including pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
Comment 1 Mart Raudsepp 2011-11-03 12:34:36 UTC
Created attachment 200586 [details] [review]
decodebin2: Use existing "caps" quark for one of the structure sets
Comment 2 Mart Raudsepp 2011-11-03 12:35:27 UTC
Created attachment 200587 [details] [review]
decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values

This allows us to easily get ahold of all pads on a stream-topology message, including
pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
Comment 3 Sebastian Dröge (slomo) 2011-11-03 12:50:01 UTC
Review of attachment 200587 [details] [review]:

Looks good, only_

::: gst/playback/gstdecodebin2.c
@@ +3470,3 @@
     elem_next = delem_next->element;
 
+    caps = _gst_element_get_linked_caps (elem_next, elem, &srcpad);

You're leaking the srcpad in the caps==NULL case
Comment 4 Mart Raudsepp 2011-11-03 13:29:19 UTC
Created attachment 200595 [details] [review]
decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values

This allows us to easily get ahold of all pads on a stream-topology message, including
pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
Comment 5 Sebastian Dröge (slomo) 2011-11-03 13:41:24 UTC
commit 5c58bcfd155b7aa6d101b32a77da35d4284cbcad
Author: Mart Raudsepp <mart.raudsepp@collabora.com>
Date:   Thu Nov 3 14:10:31 2011 +0200

    decodebin2: Post all source pads in stream-topology messages as "element-src
    
    This allows us to easily get ahold of all pads on a stream-topology message,
    pre-decoder ones, while "pad" only gives us access to the raw pads (as used 

commit cee87108176fd0b9b1c6d772d93a0ea190d8265f
Author: Mart Raudsepp <mart.raudsepp@collabora.com>
Date:   Thu Oct 20 13:04:52 2011 +0300

    decodebin2: Use existing "caps" quark for one of the structure sets