GNOME Bugzilla – Bug 663312
decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values
Last modified: 2011-11-03 13:50:11 UTC
This allows us to easily get ahold of all pads on a stream-topology message, including pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
Created attachment 200586 [details] [review] decodebin2: Use existing "caps" quark for one of the structure sets
Created attachment 200587 [details] [review] decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values This allows us to easily get ahold of all pads on a stream-topology message, including pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
Review of attachment 200587 [details] [review]: Looks good, only_ ::: gst/playback/gstdecodebin2.c @@ +3470,3 @@ elem_next = delem_next->element; + caps = _gst_element_get_linked_caps (elem_next, elem, &srcpad); You're leaking the srcpad in the caps==NULL case
Created attachment 200595 [details] [review] decodebin2: Post all source pads in stream-topology messages as "element-srcpad" values This allows us to easily get ahold of all pads on a stream-topology message, including pre-decoder ones, while "pad" only gives us access to the raw pads (as used by discoverer).
commit 5c58bcfd155b7aa6d101b32a77da35d4284cbcad Author: Mart Raudsepp <mart.raudsepp@collabora.com> Date: Thu Nov 3 14:10:31 2011 +0200 decodebin2: Post all source pads in stream-topology messages as "element-src This allows us to easily get ahold of all pads on a stream-topology message, pre-decoder ones, while "pad" only gives us access to the raw pads (as used commit cee87108176fd0b9b1c6d772d93a0ea190d8265f Author: Mart Raudsepp <mart.raudsepp@collabora.com> Date: Thu Oct 20 13:04:52 2011 +0300 decodebin2: Use existing "caps" quark for one of the structure sets