After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 663148 - Add a non-interactive test suite
Add a non-interactive test suite
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other Linux
: Normal major
: 3.2
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-11-01 09:48 UTC by David King
Modified: 2011-12-13 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
example patch, including Makefile.am changes (4.74 KB, patch)
2011-12-11 20:35 UTC, David King
committed Details | Review
crop and fileutils (4.33 KB, patch)
2011-12-12 21:11 UTC, Lucas Baudin
committed Details | Review

Description David King 2011-11-01 09:48:04 UTC
Cheese currently has test binaries, which are compiled during make all, but which must be run manually. There should be a non-interactive test suite, using the GTest and GtkTest frameworks:

http://developer.gnome.org/glib/stable/glib-Testing.html
http://developer.gnome.org/gtk3/stable/gtk3-Testing.html

This could start with simple tests, like instantiating the GTypes in libcheese, and be as advanced as trying to capture video and photos (if the hardware is available).
Comment 1 David King 2011-12-11 20:35:38 UTC
Created attachment 203221 [details] [review]
example patch, including Makefile.am changes

Attached is a patch including Lucas Baudin's (Google Code-In) current changes, originally downloaded from:

http://pastebin.com/v8QDJdKK

plus a working build system change adapted from Makefile.decl supplied with GLib.
Comment 2 Lucas Baudin 2011-12-12 21:11:19 UTC
Created attachment 203298 [details] [review]
crop and fileutils

Ah, thanks :)

Here is a patch (which applies on the top on the other one). It fixes the indentation problem, add a file_utils and a crop test.

I don't know what I could add? I thought we could add something which tests a photo is valid, but this is more a gstreamer test, and I think it will require a lot of code to test something which is not very useful (then, we'll have to maintain the test itself, etc...), since a release will never be made without opening at least one time cheese...

Any idea?
Comment 3 David King 2011-12-12 21:26:47 UTC
Hi Lucas, I think that your changes so far are great, and I think that adding more complex tests is outside the scope of your Google Code-In task. Please submit both patches to Melange, mark the task as ready to be reviewed, and I will be happy to close it as complete. Thanks!
Comment 4 David King 2011-12-13 22:19:23 UTC
Comment on attachment 203221 [details] [review]
example patch, including Makefile.am changes

I applied an improved Makfile.am change,  removed the .c file and pushed to master as commit 27cd08b9185dafab39b1bb7804314929d25f3396.
Comment 5 David King 2011-12-13 22:20:45 UTC
Comment on attachment 203298 [details] [review]
crop and fileutils

I split these changes off from the previous patch, improved them a bit and pushed them to master as commit fe532b663ad7624dcacaaf27bb7cc1c20fedab4f, thanks!