After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 662291 - basetransform: cache transformed caps where appropriate
basetransform: cache transformed caps where appropriate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 590942 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-10-20 13:05 UTC by Vincent Penquerc'h
Modified: 2011-11-08 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basetransform: cache transformed caps where appropriate (4.12 KB, patch)
2011-10-20 13:05 UTC, Vincent Penquerc'h 		none Details | Review
basetransform: cache transformed caps where appropriate (4.13 KB, patch)
2011-10-20 13:08 UTC, Vincent Penquerc'h 		needs-work Details | Review
basetransform: cache transformed caps where appropriate (4.40 KB, patch)
2011-10-20 14:36 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-10-20 13:05:17 UTC 
Speeds up negotiation a fair bit on a contrived pipeline
with a dozen colorspace conversions.

Hopefully clears out the cache every time it ought to.
Comment 1 Vincent Penquerc'h 2011-10-20 13:05:19 UTC 
Created attachment 199520 [details] [review]
basetransform: cache transformed caps where appropriate
Comment 2 Vincent Penquerc'h 2011-10-20 13:08:07 UTC 
Created attachment 199521 [details] [review]
basetransform: cache transformed caps where appropriate

Speeds up negotiation a fair bit on a contrived pipeline
with a dozen colorspace conversions.

Hopefully clears out the cache every time it ought to.


Typo fix spotted by sjoerd
Comment 3 Sebastian Dröge (slomo) 2011-10-20 14:22:44 UTC 
Comment on attachment 199521 [details] [review]
basetransform: cache transformed caps where appropriate

I think this needs some more locking. Protect the cached caps with the object lock everywhere, otherwise looks good
Comment 4 Vincent Penquerc'h 2011-10-20 14:36:27 UTC 
Created attachment 199532 [details] [review]
basetransform: cache transformed caps where appropriate

Speeds up negotiation a fair bit on a contrived pipeline
with a dozen colorspace conversions.

Hopefully clears out the cache every time it ought to.
Comment 5 Sebastian Dröge (slomo) 2011-10-20 14:54:38 UTC 
commit 168e5c0abb4c33de12c685e0efda6d4f9efdab2f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Thu Oct 20 14:02:44 2011 +0100

    basetransform: cache transformed caps where appropriate
    
    Speeds up negotiation a fair bit on a contrived pipeline
    with a dozen colorspace conversions.
    
    Hopefully clears out the cache every time it ought to.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=662291
Comment 6 Wim Taymans 2011-10-27 13:30:41 UTC 
Reverted for 0.11, needs to be redone there with the filter and all.
Comment 7 Vincent Penquerc'h 2011-11-08 12:36:43 UTC 
*** Bug 590942 has been marked as a duplicate of this bug. ***