After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661400 - rtpg722pay: G722 rtptime too fast
rtpg722pay: G722 rtptime too fast
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-10 18:05 UTC by Sjoerd Simons
Modified: 2011-10-10 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.27 KB, patch)
2011-10-10 18:05 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2011-10-10 18:05:52 UTC 
Created attachment 198729 [details] [review]
proposed patch

G722 has a samplerate of 16Khz, but due to hystorical errors the rtp clockrate is only 8khz. This needs to be taken into account when converting from bytes to time and the other way around.
Comment 1 Olivier Crête 2011-10-10 20:05:56 UTC 
Review of attachment 198729 [details] [review]:

++ on the patch, but what about the depayloader? is it correct ?
does enc ! pay ! depay ! dec work ?
Comment 2 Sjoerd Simons 2011-10-10 21:05:22 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 3 Tim-Philipp Müller 2011-10-10 21:49:26 UTC 
commit bf65acf11fd107376e5591e24f0d93de05057fab
Author: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date:   Mon Oct 10 19:01:23 2011 +0100

    gstrtpg722pay: Compensate for clockrate vs. samplerate difference
    
    The RTP clock-rate used for G722 is 8000, even though the samplerate is
    16000. Compensate for this by pretending G722 has 8 bits per sample
    instead of the 4 bits as if it were a codec that ran at half the speed,
    but with twice the number of bits. Fixes #661376