GNOME Bugzilla – Bug 661221
don't replace messages before they can be seen
Last modified: 2021-07-05 14:29:09 UTC
Currently when we post a notification that a new chat has arrived we immediately update it if an even newer line of dialog comes in. So something like: [new notification] "Nancy Grace farted on dancing with the stars!" [updated by] "haha" Currently we very quickly flash the original message and replace it almost immediately with "haha". This is pretty annoying since you can't see what you started to see and then it is overwritten with something that references what you didn't see. This compells you to go into the notification or worse into the summary area - and this is precisely what we don't want.
I just finished a patch for it. I'm testing right now, because there's some issues that I don't know if they are already in master branch. So I hope in one or two days I can push it. Also, do you think 1'5 seconds for timeout between each message is enough?
Well, in 1 hour I saw the issues I was having but in the master branch, so the patch is not doing these issues. I push it to review. Please, take into account that it is my first "long" code patch (the other is not reviewed yet). So sure it has some naming mistakes or manners mistakes. Review carefully please. I tried to follow gnome-shell guidelines, but some things are not specified.
Created attachment 230992 [details] [review] MessageTray: Add some timeout between chat notifications Until now when a user talks to you many times in no time the notifications are overrided by the newest notification, not allowing the user to follow the conversation. Adding some timeout between each chat notification fix it.
Review of attachment 230992 [details] [review]: Sorry for taking this long to review. After testing, I found a problem: if you expand the chat notification, the queue is not drained, so you only get the messages displayed up that point. Furthermore, the timeout appears to be stopped, so you actually lose messages until the notification is next hidden. I think you need to override expand() and add all messages from there.
obsolete yay!
(In reply to Carlos Soriano from comment #5) > obsolete yay! Are you sure? I don't see how the new notifications would address this ...
(In reply to Florian Müllner from comment #6) > (In reply to Carlos Soriano from comment #5) > > obsolete yay! > > Are you sure? I don't see how the new notifications would address this ... Notifications are not longer replaced immediately if another came while one is shown no? at least is what I can see...
As far as I can tell, this was never about another notification coming in, but about updates to an existing notification. That's still supposed to work as before (there's bug 744948, but that's really just that - a bug ...)
(In reply to Florian Müllner from comment #8) > As far as I can tell, this was never about another notification coming in, > but about updates to an existing notification. That's still supposed to work > as before (there's bug 744948, but that's really just that - a bug ...) oh ok.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.