GNOME Bugzilla – Bug 657769
Sync progress bar does not stop
Last modified: 2012-08-29 15:09:57 UTC
As shown in linked video, the syncing progress bar does not stop once the system is done syncing. http://www.vimeo.com/28242141 Video recorded using git master on a mythbuntu(XFCE) virtual machine. video originally shot for BGO#657526
Thank you for the bug report and the video ! Could you also provide the complete log output when reproducing the issue ? Just a piece of advice, unrelated to the bug itself : If you want to run banshee from a git checkout, you can just do a "make run"
Created attachment 195607 [details] Debug while syncing This might be a timing issue, during this run there was actually nothing to sync, but in previous runs, playlists needed to sync. Ran with the followingcomand: make run > ~/banshee.log 2>&1 I also ran a "tail -f ~/banshee.log" in another tab and following lines appeared after clicking sync, then nothing until I told it to quit. [7 Debug 21:29:36.937] Starting DAP sync [7 Debug 21:29:36.961] Starting [7 Debug 21:29:37.266] Ending DAP sync I did get a dialog box saying that "Important tasks" were running, but the details box was blank.
I experienced this error, too. Ubuntu 11.04, Banshee unstable and stable PPA, AMD64. It does not occur everytime, but I could not grasp a pattern yet.
(In reply to comment #3) > It does not occur everytime, but I could not grasp a pattern yet. Agreed, I think it is a race condition.
Is this bug related to https://bugzilla.gnome.org/show_bug.cgi?id=656590 Or is it an entirely different problem?
(In reply to comment #4) > Agreed, I think it is a race condition. Is it possible for us to provide you some more information on this issue? I don't see that a normal log file would really help...
I also see this behaviour when syncing to a device when there's no new tracks to be added.
Created attachment 210890 [details] [review] Hide the progress bar when there's nothing new to sync This patch calls the Finish() method of the ServiceStack object, when the track list to be synced on the device is empty. When the list is non-empty, this is normally achieved by add_track_job.Completed++ in IncrementAddedTracks()
Thanks for the patch Fabrice! William, do you mind testing Fabrice's patch? I would test myself but I found this bug difficult (although not impossible) to reproduce... Thanks
I'll have to recreate a virtual machine, but I have no problems testing the patch.
(In reply to comment #10) > I'll have to recreate a virtual machine, but I have no problems testing the > patch. Sounds good, ping? :)
Sorry for the delay... The patch seems to work for me.
*** Bug 677035 has been marked as a duplicate of this bug. ***
If run into the same bug and it gave me a hard time until I discovered this report. I've played around in the MD debugger and Fabrice is just right - the IncrementAddedTracks () is never called when the list is empty, hence the BatchUserJob.Completed field is never incremented (via add_track_job), and the Job never finished. The patch works as expceted and fixes the issue. Its quite crucial, as it will always happen if you sync a device that does not need syncing (because all tracks are up to date) and should go into master asap.
Comment on attachment 210890 [details] [review] Hide the progress bar when there's nothing new to sync Thanks for the patch, committed! Sorry it took so long !
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
When would be the next major software release or how I could install development version?
Vlad, banshee 2.5.0 should include this fix.