GNOME Bugzilla – Bug 65765
Add authentication icon(s) to stock.
Last modified: 2004-12-22 21:47:04 UTC
A stock authentication icon would be useful for authentication alerts and for dialogs or utilities that require an administrator password. Padlocks, keyholes, and keys are common objects for such an icon.
Is it possible to add this without breaking the API freeze in a bad way? I suspect adding new stock elements is relatively benign, and this would probably be cleared by the release comittee.
We'd like this for the HIG, is there any way to get it into a particular milestone rather than leaving it in the nebulous "future" ?
If you attach a patch and get someone to draw the icon, you could put it on 2.2 API freeze probably.
Hi Tigert/Jimmac. Would it be possible to get an icon for this? The primary place we want the icon is in dialog boxes (though I suppose it could be useful for menu items too). As Gregory says "Padlocks, keyholes, and keys are common objects for such an icon."
Created attachment 10261 [details] from Evolution
Created attachment 10262 [details] with keyhole
Here is a patch.
Created attachment 12413 [details] [review] patch
I suggest you patch the ChangeLog.
I don't understand that comment. It is common practise to attach patches without ChangeLog entries and add them when the patch is actually committed. But this patch is not suitable for committing, since there is no way to make use of the new stock icon in a MessageDialog, and there is no way to add the necessary fields for an authentication alert to a MessageDialog.
Sorry, I didn't realise that you would be the one committing that patch. Even though you can't use the icon in a GtkMessageDialog, there is nothing stopping you from using it in a regular GtkDialog. It's just an icon.
/me wonders what a door's keyhole is doing in a padlock.
Will this new stock icon be integrated in gtk+ soon, or should it be added to the libgnomeui stock icons for now (I need it for bug #103408). Regarding the icon, maybe the one I used for http://cfergeau.free.fr/auth.png would fit better (ie a question mark instead of a keyhole) (I grabbed it from the evolution icons available on jimmac's webpage, I hope it's ok)
Well, this bug will handled before GTK+ 2.4. I think it's safe to say that no additions can be made to libgnomeui for GNOME-2.2 (it was API frozen maybe two monts ago), so I don't see any point in adding them to libgnomeui at all.
My "for now" was obviously meaning "after gnome 2.2 is released" :)
Should be OK to commit. I'm not really sure how to go about "dialog integration" for this; would it be better to have a separate GtkAuthenticationDialog? I'm not sure packing extra widgets into a GtkMessageDialog makes sense. But either as GtkMessageDialog API extensions or as a new dialog type, that should be a separate bug.