After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 656928 - vp8: probe for the new tuning API to keep building with older libvpx
vp8: probe for the new tuning API to keep building with older libvpx
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 656980 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-19 18:23 UTC by Vincent Penquerc'h
Modified: 2011-08-23 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vp8: probe for the new tuning API to keep building with older libvpx (4.03 KB, patch)
2011-08-19 18:23 UTC, Vincent Penquerc'h 		none Details | Review
vp8: probe for the new tuning API to keep building with older libvpx (4.06 KB, patch)
2011-08-19 18:41 UTC, Vincent Penquerc'h 		none Details | Review
amended for comments (3.75 KB, patch)
2011-08-22 07:50 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-08-19 18:23:12 UTC 
Such as the one I have installed.
Comment 1 Vincent Penquerc'h 2011-08-19 18:23:15 UTC 
Created attachment 194256 [details] [review]
vp8: probe for the new tuning API to keep building with older libvpx
Comment 2 Vincent Penquerc'h 2011-08-19 18:41:47 UTC 
Created attachment 194260 [details] [review]
vp8: probe for the new tuning API to keep building with older libvpx

Ahem - fix the configure test program which would not actually work with the right version of libvpx :P
Comment 3 David Schleef 2011-08-20 21:51:42 UTC 
*** Bug 656980 has been marked as a duplicate of this bug. ***
Comment 4 Vincent Penquerc'h 2011-08-22 07:50:10 UTC 
Created attachment 194346 [details] [review]
amended for comments

Amended for comments on IRC to keep the property in the API when libvpx does not support it.

I don't really like this as it pulls the enum and there's no place where it makes sense to cut off. I've selected to have a dummy enum with just one "none" entry, but this is as unpalatable as any other choice I think.

Would be much nicer if it'd been an int, but I suppose keeping the property but changing its type would be nightmare for code trying to use it.
Comment 5 Sebastian Dröge (slomo) 2011-08-23 08:33:09 UTC 
commit 8d5f2c707863eeb49526cb4b889bc690ea280aa6
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Aug 23 10:32:14 2011 +0200

    configure: Add AC_MSG_CHECKING() to the VP8E_SET_TUNING presence check

commit c24d052bb7223efce1885e1577b0f9daeb3a3e7c
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Aug 19 19:17:15 2011 +0100

    vp8: probe for the new tuning API to keep building with older libvpx
    
    https://bugzilla.gnome.org/show_bug.cgi?id=656928