After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 655918 - qtdemux : qtdemux_add_fragmented_samples return error.
qtdemux : qtdemux_add_fragmented_samples return error.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.29
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-03 17:31 UTC by brian.li
Modified: 2011-09-05 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description brian.li 2011-08-03 17:31:45 UTC 
I've found that some problem in qtdemux plug-in "qtdemux_add_fragmented_samples" function,
It'll set the wrong default value for variable "res".
but TRUE(1) means not equal to GST_FLOW_OK(0).

--- a/gst/isomp4/qtdemux.c
+++ b/gst/isomp4/qtdemux.c
@@ -5138,7 +5138,7 @@
static GstFlowReturn
qtdemux_add_fragmented_samples (GstQTDemux * qtdemux)
{
   guint64 length, offset;
   GstBuffer *buf = NULL;
   GstFlowReturn ret = GST_FLOW_OK;
-  GstFlowReturn res = TRUE;
+  GstFlowReturn res = GST_FLOW_OK;
 
   offset = qtdemux->moof_offset;
   GST_DEBUG_OBJECT (qtdemux, "next moof at offset %" G_GUINT64_FORMAT, offset);
Comment 1 David Schleef 2011-08-03 20:10:54 UTC 
Could you create a patch using 'git format-patch'?  Thanks.  (otherwise, looks good)
Comment 2 Mark Nauwelaerts 2011-09-05 12:58:20 UTC 
Thanks.  Committed.

commit a3e9b676c07497152630463afd00682777b2b1df
Author: Brian Li <brian7003@gmail.com>
Date:   Mon Sep 5 14:46:29 2011 +0200

    qtdemux: fragmented support; properly init return variable value
    
    Fixes #655918.