After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 654805 - Missing gstdecklink.h in sys/decklink when doing a "make dist"
Missing gstdecklink.h in sys/decklink when doing a "make dist"
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-07-18 05:21 UTC by Tim 'mithro' Ansell
Modified: 2011-12-01 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch. (654 bytes, patch)
2011-07-18 05:57 UTC, Tim 'mithro' Ansell
committed Details | Review

Description Tim 'mithro' Ansell 2011-07-18 05:21:49 UTC
The files in sys/decklink all refer to a file call gstdecklink.h which is not found in that directory. Maybe someone forgot to commit it?
Comment 1 Tim 'mithro' Ansell 2011-07-18 05:23:57 UTC
Complete error message from compile below;

make[4]: Entering directory `/home/tansell/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643/sys/decklink'
\
#	source='gstdecklinksrc.cpp' object='libgstdecklink_la-gstdecklinksrc.lo' libtool=yes 
/bin/sh ../../libtool  --tag=CXX --tag=disable-static  --mode=compile g++ -DHAVE_CONFIG_H -I. -I../..  -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2   -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2    -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Werror -Wno-non-virtual-dtor  -g   -DGST_DISABLE_DEPRECATED    -g -Wall -O2 -Wno-error -c -o libgstdecklink_la-gstdecklinksrc.lo `test -f 'gstdecklinksrc.cpp' || echo './'`gstdecklinksrc.cpp
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I../.. -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_DEPRECATED -Wall -Wmissing-declarations -Wredundant-decls -Wwrite-strings -Wformat-nonliteral -Wformat-security -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Werror -Wno-non-virtual-dtor -g -DGST_DISABLE_DEPRECATED -g -Wall -O2 -Wno-error -c gstdecklinksrc.cpp  -fPIC -DPIC -o .libs/libgstdecklink_la-gstdecklinksrc.o
gstdecklinksrc.cpp:39:25: error: gstdecklink.h: No such file or directory
In file included from gstdecklinksrc.cpp:40:
gstdecklinksrc.h:73: error: ‘GstDecklinkModeEnum’ does not name a type
gstdecklinksrc.h:74: error: ‘GstDecklinkConnectionEnum’ does not name a type
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_base_init(void*)’:
gstdecklinksrc.cpp:154: error: ‘gst_decklink_mode_get_template_caps’ was not declared in this scope
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_class_init(GstDecklinkSrcClass*)’:
gstdecklinksrc.cpp:185: error: ‘GST_TYPE_DECKLINK_MODE’ was not declared in this scope
gstdecklinksrc.cpp:185: error: ‘GST_DECKLINK_MODE_NTSC’ was not declared in this scope
gstdecklinksrc.cpp:191: error: ‘GST_TYPE_DECKLINK_CONNECTION’ was not declared in this scope
gstdecklinksrc.cpp:191: error: ‘GST_DECKLINK_CONNECTION_SDI’ was not declared in this scope
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_init(GstDecklinkSrc*, GstDecklinkSrcClass*)’:
gstdecklinksrc.cpp:269: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:269: error: ‘GST_DECKLINK_MODE_NTSC’ was not declared in this scope
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_set_property(GObject*, guint, const GValue*, GParamSpec*)’:
gstdecklinksrc.cpp:284: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:284: error: ‘GstDecklinkModeEnum’ was not declared in this scope
gstdecklinksrc.cpp:284: error: expected ‘;’ before ‘g_value_get_enum’
gstdecklinksrc.cpp:287: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:288: error: ‘GstDecklinkConnectionEnum’ was not declared in this scope
gstdecklinksrc.cpp:288: error: expected ‘;’ before ‘g_value_get_enum’
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_get_property(GObject*, guint, GValue*, GParamSpec*)’:
gstdecklinksrc.cpp:307: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:310: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp: In function ‘gboolean gst_decklink_src_start(GstElement*)’:
gstdecklinksrc.cpp:379: error: expected initializer before ‘*’ token
gstdecklinksrc.cpp:415: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:417: error: ‘GST_DECKLINK_CONNECTION_SDI’ was not declared in this scope
gstdecklinksrc.cpp:420: error: ‘GST_DECKLINK_CONNECTION_HDMI’ was not declared in this scope
gstdecklinksrc.cpp:423: error: ‘GST_DECKLINK_CONNECTION_OPTICAL_SDI’ was not declared in this scope
gstdecklinksrc.cpp:426: error: ‘GST_DECKLINK_CONNECTION_COMPONENT’ was not declared in this scope
gstdecklinksrc.cpp:429: error: ‘GST_DECKLINK_CONNECTION_COMPOSITE’ was not declared in this scope
gstdecklinksrc.cpp:432: error: ‘GST_DECKLINK_CONNECTION_SVIDEO’ was not declared in this scope
gstdecklinksrc.cpp:443: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:443: error: ‘GST_DECKLINK_CONNECTION_COMPOSITE’ was not declared in this scope
gstdecklinksrc.cpp:452: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:452: error: ‘GST_DECKLINK_CONNECTION_COMPOSITE’ was not declared in this scope
gstdecklinksrc.cpp:453: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:453: error: ‘GST_DECKLINK_CONNECTION_COMPONENT’ was not declared in this scope
gstdecklinksrc.cpp:454: error: ‘struct _GstDecklinkSrc’ has no member named ‘connection’
gstdecklinksrc.cpp:454: error: ‘GST_DECKLINK_CONNECTION_SVIDEO’ was not declared in this scope
gstdecklinksrc.cpp:483: error: ‘mode’ was not declared in this scope
gstdecklinksrc.cpp:483: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:483: error: ‘gst_decklink_get_mode’ was not declared in this scope
gstdecklinksrc.cpp: In function ‘GstCaps* gst_decklink_src_video_src_getcaps(GstPad*)’:
gstdecklinksrc.cpp:828: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:828: error: ‘gst_decklink_mode_get_caps’ was not declared in this scope
gstdecklinksrc.cpp: In function ‘void gst_decklink_src_task(void*)’:
gstdecklinksrc.cpp:1031: error: expected initializer before ‘*’ token
gstdecklinksrc.cpp:1057: error: ‘mode’ was not declared in this scope
gstdecklinksrc.cpp:1057: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:1057: error: ‘gst_decklink_get_mode’ was not declared in this scope
gstdecklinksrc.cpp:1089: error: ‘struct _GstDecklinkSrc’ has no member named ‘mode’
gstdecklinksrc.cpp:1089: error: ‘gst_decklink_mode_get_caps’ was not declared in this scope
make[4]: *** [libgstdecklink_la-gstdecklinksrc.lo] Error 1
make[4]: Leaving directory `/home/tansell/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643/sys/decklink'
make[3]: *** [decklink] Error 2
make[3]: Leaving directory `/home/tansell/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643/sys'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/tansell/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/tansell/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643'
make: *** [debian/stamp-makefile-build] Error 2
tansell@tansell-glaptop:~/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643$

tansell@tansell-glaptop:~/gstreamer-debs/gst-plugins-bad0.10-0.10.22.1~git20110715131643/sys/decklink$ ls
DeckLinkAPI.h            LinuxCOM.h  Makefile.am  capture.cpp  gstdecklink.cpp      gstdecklinksink.h   gstdecklinksrc.h
DeckLinkAPIDispatch.cpp  Makefile    Makefile.in  capture.h    gstdecklinksink.cpp  gstdecklinksrc.cpp


Latest commit
$ git log
commit f6f885ddb80128cca48396caeb549fbbd7bb253c
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Sat Jul 16 13:51:44 2011 +0200

    tsdemux: whoops, tsdemux isn't ready yet for primary rank :)
Comment 2 Tim 'mithro' Ansell 2011-07-18 05:57:17 UTC
Created attachment 192160 [details] [review]
Patch.
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-12-01 13:40:06 UTC
Sorry this was independently fixed.

> git show 8132a5d4
commit 8132a5d46eff58217bad31cb3fc0495846fd0f01
Author: Edward Hervey <edward.hervey@collabora.co.uk>
Date:   Thu Aug 4 11:28:30 2011 +0200

    decklink: Add gstdecklink.h to list of headers

diff --git a/sys/decklink/Makefile.am b/sys/decklink/Makefile.am
index ffa4ac2..c84d871 100644
--- a/sys/decklink/Makefile.am
+++ b/sys/decklink/Makefile.am
@@ -20,6 +20,7 @@ libgstdecklink_la_SOURCES = \
        DeckLinkAPIDispatch.cpp
 
 noinst_HEADERS = \
+       gstdecklink.h \
        gstdecklinksrc.h \
        gstdecklinksink.h \
        capture.h \