After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 653709 - [ximagesrc] sets DISCONT on half the buffers
[ximagesrc] sets DISCONT on half the buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 653582
Blocks:
 
 
Reported: 2011-06-30 04:52 UTC by David Schleef
Modified: 2011-08-09 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ximagesrc: clear flags on buffer reuse (1.13 KB, patch)
2011-08-09 08:06 UTC, Vincent Penquerc'h 		committed Details | Review

Description David Schleef 2011-06-30 04:52:47 UTC 
+++ This bug was initially created as a clone of Bug #653582 +++

gst-launch ximagesrc use-damage=false ! fakesink -v

/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = "chain   ******* < (3145728 bytes, timestamp: 0:00:00.000051683, duration: 0:00:00.039948317, offset: -1, offset_end: -1, flags: 32 discont ) 0x1392020"
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = "chain   ******* < (3145728 bytes, timestamp: 0:00:00.040000000, duration: 0:00:00.040000000, offset: -1, offset_end: -1, flags: 0 ) 0x13920f0"
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = "chain   ******* < (3145728 bytes, timestamp: 0:00:00.080000000, duration: 0:00:00.040000000, offset: -1, offset_end: -1, flags: 32 discont ) 0x1392020"
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = "chain   ******* < (3145728 bytes, timestamp: 0:00:00.120000000, duration: 0:00:00.040000000, offset: -1, offset_end: -1, flags: 0 ) 0x13920f0"
/GstPipeline:pipeline0/GstFakeSink:fakesink0: last-message = "chain   ******* < (3145728 bytes, timestamp: 0:00:00.160000000, duration: 0:00:00.040000000, offset: -1, offset_end: -1, flags: 32 discont ) 0x1392020"

What's up with the DISCONT flag!?
Comment 1 Vincent Penquerc'h 2011-08-09 08:06:40 UTC 
Created attachment 193462 [details] [review]
ximagesrc: clear flags on buffer reuse

This will ensure a logically new buffer does not keep flags from
a previous use of that buffer (eg, DISCONT would be set on the first
buffer, and mistakenly kept when reused).
Comment 2 Sebastian Dröge (slomo) 2011-08-09 08:20:09 UTC 
commit 26993420c06aacfa52c883dea04d07ad542b079f
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Aug 9 09:05:31 2011 +0100

    ximagesrc: clear flags on buffer reuse
    
    This will ensure a logically new buffer does not keep flags from
    a previous use of that buffer (eg, DISCONT would be set on the first
    buffer, and mistakenly kept when reused).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=653709