After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 651875 - Smileys not supported in notifications
Smileys not supported in notifications
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: message-tray
3.0.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 657701 670340 (view as bug list)
Depends on: 653033
Blocks:
 
 
Reported: 2011-06-04 20:50 UTC by xenhu134
Modified: 2019-11-13 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description xenhu134 2011-06-04 20:50:19 UTC
If I receive a message from someone, I get a brief notification popup at the bottom of the screen. This notification area should support smileys, now I get the plain character representations.
Comment 1 Guillaume Desmottes 2011-06-06 13:49:27 UTC
That's done by gnome-shell, not Empathy.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-08-30 13:17:44 UTC
*** Bug 657701 has been marked as a duplicate of this bug. ***
Comment 3 Xavier Claessens 2011-08-30 13:17:58 UTC
gnome-shell should be using webkit to render the chat notification, IMO. So we can do like in empathy.
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-08-30 13:22:50 UTC
No. Zaspire implemented images in Pango attrs, so let's use that.
Comment 5 Xavier Claessens 2011-08-30 13:28:58 UTC
do you have a URL explaining how I can have images in pango attrs? I did such hacks for maemo by adding place in the layout then render the pixbuf with cairo on top, but that's not going to be easy in complex text view as chats...
Comment 6 Dan Winship 2011-08-30 13:34:16 UTC
it's in bug 653033. the patch there adds support for <img> tags
Comment 7 Xavier Claessens 2011-08-31 10:05:35 UTC
ok that seems good. thanks.

However, this is not that simple to fix actually: If I replace smileys with <img src="file://foo/bar.png"> then url detector in messageTray.js will replace that url with a <span> which wil break the smiley.

In empathy what we do is replacing urls and then detect smileys in text between each urls and not on the whole text after the replacement.

So should the smiley detected be added to messageTray.js so it can interact with the url detector code there? And probably add a method addBodyWithSmileys() to not replace with smileys in all notifications but only the chats?
Comment 8 Xavier Claessens 2011-09-01 11:29:33 UTC
I've made a quick hack to replace smileys to unicode chars, but it seems the police used by gnome-shell can't display them 
Comment 9 Xavier Claessens 2011-09-01 11:29:56 UTC

Comment 10 Xavier Claessens 2011-09-01 11:30:23 UTC
hm, bugzilla does not display then neither it seems :(
Comment 11 Florian Müllner 2012-02-18 11:28:31 UTC
*** Bug 670340 has been marked as a duplicate of this bug. ***
Comment 12 Emmanuele Bassi (:ebassi) 2012-11-02 12:45:53 UTC
(In reply to comment #5)
> do you have a URL explaining how I can have images in pango attrs? I did such
> hacks for maemo by adding place in the layout then render the pixbuf with cairo
> on top, but that's not going to be easy in complex text view as chats...

you can create custom shape renderers for PangoAttributes; there is a demo of the API inside gtk+/demos/gtk-demo/rotated_text.c. it should be working with Clutter and St's widgets by default, since we use PangoCairo internally.
Comment 13 Got u 2014-04-28 20:51:07 UTC
(In reply to comment #12)
> (In reply to comment #5)
> > do you have a URL explaining how I can have images in pango attrs? I did such
> > hacks for maemo by adding place in the layout then render the pixbuf with cairo
> > on top, but that's not going to be easy in complex text view as chats...
> 
> you can create custom shape renderers for PangoAttributes; there is a demo of
> the API inside gtk+/demos/gtk-demo/rotated_text.c. it should be working with
> Clutter and St's widgets by default, since we use PangoCairo internally.
Comment 14 Alexandre Franke 2019-11-13 16:43:39 UTC
Emoji work fine in notifications nowadays and that’s what people use in chat. Closing as this is not relevant anymore.