GNOME Bugzilla – Bug 650484
h264parse should increase max allowed PPS id from 31 to 255
Last modified: 2011-10-29 15:24:35 UTC
Currently, the h264parse element limits the max allowed PPS id to 31. h264parse should be updated to accept a max PPS id of 255. According to section 7.4.2.2 in the H264 spec, the PPS id may range from 0-255. Here's the info from 7.4.2.2 in the H264 spec: pic_parameter_set_id identifies the picture parameter set that is referred to in the slice header. The value of pic_parameter_set_id shall be in the range of 0 to 255, inclusive. seq_parameter_set_id refers to the active sequence parameter set. The value of seq_parameter_set_id shall be in the range of 0 to 31, inclusive. I'm pasting the proposed patch below. I'll also add it as an attachment. Index: gsth264parse.h =================================================================== --- gsth264parse.h (revision 3171) +++ gsth264parse.h (working copy) @@ -48,7 +48,7 @@ typedef struct _GstH264Pps GstH264Pps; #define MAX_SPS_COUNT 32 -#define MAX_PPS_COUNT 32 +#define MAX_PPS_COUNT 256 #define CLOCK_BASE 9LL #define CLOCK_FREQ (CLOCK_BASE * 10000)
commit a898d147ba84ad9bcfceac9e86c171155e36d3b3 Author: David Schleef <ds@schleef.org> Date: Wed May 18 13:35:34 2011 -0700 h264parse: max pps is 255 Fixes #650484.