GNOME Bugzilla – Bug 649902
Implement AtkTextSelection
Last modified: 2021-06-10 11:25:39 UTC
Conclusion from the ATK Hackfest regarding bug 638378: * We are planning on notifying ATs of property changes via property-change events which contain the old and new information. Changes in text selection apply here as well. * We will need an object ('AtkTextSelection') which reflects a current text selection. * Properties needed: * Start offset (where the caret was) * End offset (where the caret is) * Selection number (because AtkText supports multiple selections) * Joanie would also like to have the string if possible and makes sense. :-)
[Mass-reassigning open atk bug reports for better trackability as requested in https://bugzilla.gnome.org/show_bug.cgi?id=653179 . PLEASE NOTE: If you have watched the previous assignee of this bug report as a workaround for actually getting notified of changes in atk bugs, you yourself will now have to add atk-maint@gnome.bugs to your watchlist at the bottom of https://bugzilla.gnome.org/userprefs.cgi?tab=email to keep watching atk bug reports in GNOME Bugzilla. Sorry for the noise: Feel free to filter for this comment in order to mass-delete the triggered bugmail.]
Created attachment 191511 [details] [review] Patch.
It seems ok, but I would like to test it first, and I don't have a proper environment right now. I will try to do that during the weekend.
I do not think this is needed. In the text interface you have: selection to give start and end offset for the selection text to get the text between two offsets For the notification: it would be possible to use detail1,2 for the text offsets and the variant for the text change in the TextSelectionChanged signal. Currently this signal always sends 0,0,"" as parameters.
(In reply to comment #3) > I would like to test it first, and I don't have a proper environment right now. > I will try to do that during the weekend. API: Did you have a chance to do so?
(In reply to comment #5) > (In reply to comment #3) > > I would like to test it first, and I don't have a proper environment right now. > > I will try to do that during the weekend. > > API: Did you have a chance to do so? We briefly talked about this during the last ATK hackfest. Comment 4 is a consequence of that. And as that comment say, right now we are not sure if this is required. We would need to re-think this, so we can retake this in the future if required.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of atk, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a ticket at https://gitlab.gnome.org/GNOME/atk/-/issues/ Thank you for your understanding and your help.