After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 649159 - i18n of column headers does not work
i18n of column headers does not work
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2011-05-02 08:26 UTC by Gabor Kelemen
Modified: 2011-05-02 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace NC_ with N_, add translator comment (1.36 KB, patch)
2011-05-02 08:30 UTC, Gabor Kelemen 		none Details | Review
Use the g_dpgettext2 function (868 bytes, patch)
2011-05-02 09:23 UTC, Gabor Kelemen 		none Details | Review

Description Gabor Kelemen 2011-05-02 08:26:43 UTC 
When opening an archive, the column headers (Size, Type, Date Modified and Location) in the list of the archive contents do not show up translated. This is because these are marked for translation with NC_ (in src/fr-window.c), but a plain gettext call is used later to actually translate them. Docs[1] say g_dpgettext2() has to be used with the NC_ macro.

This was introduced in bug #611359 which was just asking for translator comment, not context.

[1]: http://developer.gnome.org/glib/stable/glib-I18N.html#NC-:CAPS
Comment 1 Gabor Kelemen 2011-05-02 08:30:10 UTC 
Created attachment 187014 [details] [review]
Replace NC_ with N_,  add translator comment
Comment 2 Paolo Bacchilega 2011-05-02 08:48:55 UTC 
I think it's better to keep the context and use g_dpgettext2
Comment 3 Gabor Kelemen 2011-05-02 09:23:58 UTC 
Created attachment 187019 [details] [review]
Use the g_dpgettext2 function

As you wish.
Comment 4 Paolo Bacchilega 2011-05-02 10:50:51 UTC 
patch pushed to master, thank you.