After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 648245 - mpegtsdemux: truncates last buffer
mpegtsdemux: truncates last buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 654220 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-04-19 20:37 UTC by David Schleef
Modified: 2011-10-03 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MPEG ts file (9.55 KB, text/texmacs)
2011-04-19 20:37 UTC, David Schleef 		  Details
mpegtsdemux: fix scanning stopping too early (1.81 KB, patch)
2011-09-30 17:59 UTC, Vincent Penquerc'h 		committed Details | Review

Description David Schleef 2011-04-19 20:37:21 UTC 
Created attachment 186315 [details]
MPEG ts file

In the attached file, the last H.264 AU is 2623 bytes.  For the last AU, mpegtsdemux outputs two buffers, of sizes 170 and 2208, which sum to 2378.  This neatly misses 245 bytes, which is the size of the payload in the last two TS packets, 184 and 61 bytes.
Comment 1 David Schleef 2011-07-08 22:06:00 UTC 
*** Bug 654220 has been marked as a duplicate of this bug. ***
Comment 2 Edward Hervey 2011-07-14 20:11:07 UTC 
commit a82483e36772467de9d00dcca52214bcf548df6a
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Thu Jul 14 22:08:56 2011 +0200

    mpegtsbase: Split up whether we saw a PAT and its offset
    
    Fixes the issue with streams that don't set an offset on their buffers,
    like those coming from hlsdemux.
    
    Fixes #653481
Comment 3 Edward Hervey 2011-07-14 20:11:58 UTC 
doh, wrong bug :) ignore previous message
Comment 4 Vincent Penquerc'h 2011-09-30 17:59:00 UTC 
Created attachment 197897 [details] [review]
mpegtsdemux: fix scanning stopping too early
Comment 5 Sebastian Dröge (slomo) 2011-10-03 09:15:40 UTC 
commit e4856a29653815c45913edb58f64bee86b05d83b
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Fri Sep 30 18:54:04 2011 +0100

    mpegtsdemux: fix scanning stopping too early
    
    https://bugzilla.gnome.org/show_bug.cgi?id=648245