After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647942 - [pango] Use different Pango contexts for the different subclasses
[pango] Use different Pango contexts for the different subclasses
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-16 14:33 UTC by Sebastian Dröge (slomo)
Modified: 2011-04-17 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pango: Create a new pango context for every subclass (2.08 KB, patch)
2011-04-16 14:33 UTC, Sebastian Dröge (slomo) 		committed Details | Review
{clock,time}overlay: Only set the global pango context options once in class_init (4.75 KB, patch)
2011-04-16 14:33 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2011-04-16 14:33:03 UTC 
See attached patch, should explain everything
Comment 1 Sebastian Dröge (slomo) 2011-04-16 14:33:32 UTC 
Created attachment 186073 [details] [review]
pango: Create a new pango context for every subclass

timeoverlay/clockoverlay are setting some global options
on the context that shouldn't be used for the generic textoverlay.
Comment 2 Sebastian Dröge (slomo) 2011-04-16 14:33:45 UTC 
Created attachment 186074 [details] [review]
{clock,time}overlay: Only set the global pango context options once in class_init

Instead of doing it over and over again when instantiating a new instance.
Comment 3 Sebastian Dröge (slomo) 2011-04-17 12:23:29 UTC 
commit 72b142bfdfdb70b324c5d0805ec8318a9a687128
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Apr 16 16:21:39 2011 +0200

    {clock,time}overlay: Only set the global pango context options once in class
    
    Instead of doing it over and over again when instantiating a new instance.

commit 9ee7398faeb48221dacaabf48990444dd96d4211
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Sat Apr 16 16:18:40 2011 +0200

    pango: Create a new pango context for every subclass
    
    timeoverlay/clockoverlay are setting some global options
    on the context that shouldn't be used for the generic textoverlay.