After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 647842 - [faac] Detect ADTS/raw output in the downstream caps
[faac] Detect ADTS/raw output in the downstream caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.23
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-15 08:34 UTC by Sebastian Dröge (slomo)
Modified: 2011-05-14 10:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
make outputformat detect from downstream caps (5.68 KB, patch)
2011-04-15 08:46 UTC, Benjamin Gaignard 		needs-work Details | Review
make outputformat detect from downstream caps (6.55 KB, patch)
2011-04-15 09:25 UTC, Benjamin Gaignard 		committed Details | Review

Description Sebastian Dröge (slomo) 2011-04-15 08:34:35 UTC 
Currently ADTS/raw output can be selected by a property but to make negotiation work automatically it's required to detect this from the downstream caps. Bug #647748 has a new aac encoder element that properly implements this and could be adapted to faac
Comment 1 Benjamin Gaignard 2011-04-15 08:46:56 UTC 
Created attachment 186004 [details] [review]
make outputformat detect from downstream caps
Comment 2 Sebastian Dröge (slomo) 2011-04-15 08:57:45 UTC 
Comment on attachment 186004 [details] [review]
make outputformat detect from downstream caps

Looks good to me but that property should be removed completely, you can always get the information from the caps. And you should decide for one output format if downstream doesn't care instead of just keeping the value that is currently in faac->outputformat
Comment 3 Benjamin Gaignard 2011-04-15 09:25:13 UTC 
Created attachment 186007 [details] [review]
make outputformat detect from downstream caps 

make outputformat detect from downstream caps and completly remove outputformat property
Comment 4 Sebastian Dröge (slomo) 2011-04-15 10:01:33 UTC 
Review of attachment 186007 [details] [review]:

::: ext/faac/gstfaac.c
@@ +420,3 @@
+        faac->outputformat = 0;
+      } else {
+        GST_DEBUG_OBJECT (faac, "unknown stream-format: %s", str);

Set one of the outputformats here
Comment 5 Sebastian Dröge (slomo) 2011-04-19 08:00:47 UTC 
Will push it with that change after the release.
Comment 6 Sebastian Dröge (slomo) 2011-05-14 10:15:30 UTC 
commit 31d408e22e852ce638086459a855807b4121c4eb
Author: benjamin gaignard <benjamin.gaignard@linaro.org>
Date:   Fri Apr 15 11:19:20 2011 +0200

    faac: Detect output format from downstream caps change unit test