After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646967 - rtpsession: make iterate_internal_links MT-safe
rtpsession: make iterate_internal_links MT-safe
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal blocker
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-06 22:12 UTC by Håvard Graff (hgr)
Modified: 2011-04-08 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.97 KB, patch)
2011-04-06 22:12 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2011-04-06 22:12:24 UTC
Created attachment 185372 [details] [review]
patch

The request-pads could be in the process of being freed while this is being called. By locking and reffing and checking, this should now be MT-safe.

This has been observed crashing both in tests and in the product.
Comment 1 Sebastian Dröge (slomo) 2011-04-08 12:42:36 UTC
commit f8370bb2a898eccb10e8771d9ab4c09be35d2db1
Author: Havard Graff <havard.graff@tandberg.com>
Date:   Fri Nov 26 15:20:04 2010 +0100

    rtpsession: make iterate_internal_links MT-safe