After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646508 - gnome-desktop thumbnails should use g_get_user_cache_dir()
gnome-desktop thumbnails should use g_get_user_cache_dir()
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: libgnome-desktop
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
: 523174 670112 674019 675169 675583 (view as bug list)
Depends on:
Blocks: 523057 646644 675401
 
 
Reported: 2011-04-02 04:38 UTC by William Jon McCann
Modified: 2012-06-13 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use XDG cache dir for thumbnails (3.62 KB, patch)
2011-04-03 01:01 UTC, William Jon McCann
none Details | Review
Use XDG cache dir for thumbnails (1.42 KB, patch)
2011-04-03 01:01 UTC, William Jon McCann
none Details | Review
Use XDG cache dir for thumbnails (1.47 KB, patch)
2011-04-03 01:01 UTC, William Jon McCann
none Details | Review
Use XDG cache dir for thumbnails (1.46 KB, patch)
2011-04-03 01:02 UTC, William Jon McCann
none Details | Review
Move thumbnails into XDG_CACHE_HOME (3.56 KB, patch)
2012-05-03 20:11 UTC, William Jon McCann
reviewed Details | Review
thumbnail: Modify to follow the XDG Basedir Spec (5.74 KB, patch)
2012-05-03 20:13 UTC, William Jon McCann
reviewed Details | Review

Description William Jon McCann 2011-04-02 04:38:30 UTC
It would be nice to store thumbnail cache data in g_get_user_cache_dir() instead
of a dotfile.
Comment 1 Sebastian 2011-04-02 21:10:08 UTC
I just checked the current git HEAD of nautilus, with:
grep -RC 5 g_get_home *

I couldnt find any indication that nautilus saves the thumbnails in ~/ as a dotfile.

Could you provide the name of the particullar dotfile you are reporting?

P.S. never the less I saw that there are still a lot of references to ~/.gnome2 I wonder what that has got to do in a gnome3 application.
Comment 2 Cosimo Cecchi 2011-04-02 23:33:11 UTC
-> gnome-desktop

It's gnome-desktop that create those thumbnails, and stores it in ~/.thumbnails.
Comment 3 William Jon McCann 2011-04-03 01:01:19 UTC
Created attachment 185005 [details] [review]
Use XDG cache dir for thumbnails
Comment 4 William Jon McCann 2011-04-03 01:01:36 UTC
Created attachment 185006 [details] [review]
Use XDG cache dir for thumbnails
Comment 5 William Jon McCann 2011-04-03 01:01:53 UTC
Created attachment 185007 [details] [review]
Use XDG cache dir for thumbnails
Comment 6 William Jon McCann 2011-04-03 01:02:01 UTC
Created attachment 185008 [details] [review]
Use XDG cache dir for thumbnails
Comment 8 William Jon McCann 2011-04-03 18:23:19 UTC
*** Bug 523174 has been marked as a duplicate of this bug. ***
Comment 9 Cosimo Cecchi 2012-02-15 00:38:28 UTC
*** Bug 670112 has been marked as a duplicate of this bug. ***
Comment 10 Cosimo Cecchi 2012-04-13 02:10:17 UTC
*** Bug 674019 has been marked as a duplicate of this bug. ***
Comment 11 William Jon McCann 2012-05-03 20:09:35 UTC
*** Bug 675169 has been marked as a duplicate of this bug. ***
Comment 12 William Jon McCann 2012-05-03 20:11:55 UTC
Created attachment 213404 [details] [review]
Move thumbnails into XDG_CACHE_HOME
Comment 13 William Jon McCann 2012-05-03 20:13:33 UTC
Created attachment 213405 [details] [review]
thumbnail: Modify to follow the XDG Basedir Spec
Comment 14 Matthias Clasen 2012-05-05 19:28:46 UTC
Review of attachment 213404 [details] [review]:

Looks good to me, fwiw
Comment 15 Matthias Clasen 2012-05-05 19:29:29 UTC
Review of attachment 213405 [details] [review]:

looks good, but we should get the spec on fd.o and refer to that as the canonical version.
Comment 16 Cosimo Cecchi 2012-05-07 13:38:55 UTC
*** Bug 675583 has been marked as a duplicate of this bug. ***
Comment 17 Javier Jardón (IRC: jjardon) 2012-05-08 02:00:17 UTC
(In reply to comment #15)
> Review of attachment 213405 [details] [review]:
> 
> looks good, but we should get the spec on fd.o and refer to that as the
> canonical version.

Bug filed here: https://bugs.freedesktop.org/show_bug.cgi?id=49607
Comment 18 Matthias Clasen 2012-06-13 14:45:41 UTC
The thumbnail spec change has been pushed last week, so we should go ahead with this