After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646495 - hlsdemux: Add missing patches from my local branch
hlsdemux: Add missing patches from my local branch
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-01 23:33 UTC by Andoni Morales
Modified: 2011-04-04 07:14 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Andoni Morales 2011-04-01 23:33:23 UTC
Hi,

After seeing two commits in the hlsdemux element that I had already fixed I have dug in my local branches and I noticed 3 missing commits. You can find it in my hls branch [1].

The first commit make use of a GstAdapter to store the downloaded buffers of a fragment instead of using gst_buffer_join for each buffer. This reduce the usage of CPU considerably at the end of the fragment when gst_buffer_join() becomes too slow, probably because it requires a memcopy.

The second one removes the list of media files when a playlist is updated, otherwise the media files parsed in the downloaded playlist are appended to the current list instead of replacing the existing ones.

The 3rd one just checks properly that the downloaded playlist is properly encoded in utf-8.




[1]https://gitorious.org/ylatuya-gstreamer/gst-plugins-bad/commits/hls
Comment 1 Sebastian Dröge (slomo) 2011-04-04 07:14:56 UTC
commit 650418b9d86273af9ce19af536ad8665658c2162
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Sat Apr 2 01:21:34 2011 +0200

    hlsdemux: validate properly utf-8 playlist

commit 650142f0549ffe62f249e78084d038abcc574980
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Sat Apr 2 01:10:37 2011 +0200

    hlsdemux: m3u8: clear the list of media files before updating the playlist

commit e13ef203e3fc06804cebf5b347412cbe541f3a40
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Sat Apr 2 01:08:02 2011 +0200

    hlsdemux: use and adapter instead of costful buffer joins