After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645787 - Broken PGP/MIME signature verification
Broken PGP/MIME signature verification
Status: RESOLVED FIXED
Product: gmime
Classification: Other
Component: general
2.4.x
Other Linux
: Normal major
: ---
Assigned To: Jeffrey Stedfast
Jeffrey Stedfast
Depends on:
Blocks:
 
 
Reported: 2011-03-27 00:15 UTC by Thomas Jost
Modified: 2011-03-27 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible fix (725 bytes, patch)
2011-03-27 00:15 UTC, Thomas Jost 		none Details | Review

Description Thomas Jost 2011-03-27 00:15:01 UTC 
Created attachment 184329 [details] [review]
Possible fix

Since 2.4.23, PGP/MIME signature verification is broken. Signatures that were previously reporting GMIME_SIGNATURE_STATUS_GOOD are now returning some other signature status.

I ran "git bisect" in the source repo and found than the following commit is the first that is affected:
2e2cc177f70088f36dde8127c2f1be58b7606f64

It looks like signer->status is no longer being set for good signatures for some reason.

2 simple ways to restore the previous correct behaviour:
- revert this commit
- apply the attached patch (that may be called a partial revert...).

This issue was found with notmuch [1], and more specifically Jameson Rollin's "crypto" branch [2], on Arch Linux and Debian.
A bug regarding the same issue has also been opened on the Debian bug tracking system [3].

[1] http://notmuchmail.org/
[2] git://finestructure.net/notmuch
[3] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=619783
Comment 1 Jeffrey Stedfast 2011-03-27 01:33:17 UTC 
doh! Fixed in git master, thanks! I'll make a new release shortly.
Comment 2 Jeffrey Stedfast 2011-03-27 18:46:11 UTC 
just an FYI, but I've released GMime 2.4.24 (the Debian maintainer has been notified, but I don't know the Arch maintainer)