After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645781 - GtkAlignment should be deprecated
GtkAlignment should be deprecated
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.3.x
Other Linux
: Normal normal
: 3.4
Assigned To: gtk-bugs
gtk-bugs
deprecations
Depends on: 645780
Blocks:
 
 
Reported: 2011-03-26 20:52 UTC by Javier Jardón (IRC: jjardon)
Modified: 2014-05-22 02:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gtkbutton: Deprecate GtkAlignment related api (3.35 KB, patch)
2012-02-28 15:59 UTC, Javier Jardón (IRC: jjardon)
none Details | Review

Description Javier Jardón (IRC: jjardon) 2011-03-26 20:52:51 UTC
The desired effect can be achieved by using the "halign", "valign" and "margin" properties on the child widget, so GtkAlignment should not be used in new code.
Comment 1 Matthias Clasen 2011-05-04 12:51:59 UTC
Here is my checklist of things to do before any new deprecations:

- Ensure the new api actually fully covers all use cases of the old (can maybe
use reftests)
- Make the gtk tree free of the old api
- Write good docs (migration guide), and cross-references from old to new api
- Add the actual deprecation
Comment 2 Matthias Clasen 2011-05-06 21:29:48 UTC
I've added some reftests in tests/reftests/alignment-props.ui
Comment 3 Javier Jardón (IRC: jjardon) 2012-02-28 15:59:41 UTC
Created attachment 208598 [details] [review]
gtkbutton: Deprecate GtkAlignment related api
Comment 4 Matthias Clasen 2012-03-02 11:52:06 UTC
Still need to remove uses of GtkAlignment in gtkbutton.c and gtktreeviewcolumn.c