After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645420 - [scaletempo] Incorrectly handles new segments with stop == -1
[scaletempo] Incorrectly handles new segments with stop == -1
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-21 16:33 UTC by Chris E Jones
Modified: 2011-03-22 12:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to stop scaletempo from scaling segment stop time when it is set to -1 (755 bytes, application/octet-stream)
2011-03-21 16:33 UTC, Chris E Jones 		  Details
Fix code style of the previous patch (747 bytes, patch)
2011-03-21 16:36 UTC, Chris E Jones 		committed Details | Review

Description Chris E Jones 2011-03-21 16:33:49 UTC 
Created attachment 183962 [details]
Patch to stop scaletempo from scaling segment stop time when it is set to -1

This is a regression caused by the fix for bug #599903

segment stop == -1 needs to be treated as a special case, otherwise it is scaled by the applied rate and trips an assertion that tests that the segment starts before it ends.
Comment 1 Chris E Jones 2011-03-21 16:36:40 UTC 
Created attachment 183964 [details] [review]
Fix code style of the previous patch
Comment 2 Sebastian Dröge (slomo) 2011-03-22 12:47:46 UTC 
Thanks but please use "git format-patch" style patches in the future :)

commit 1c4f32b2795b0b297a837af64e15dfa460b47461
Author: Chris E Jones <chris@chrisejones.com>
Date:   Tue Mar 22 13:46:42 2011 +0100

    scaletempo: Correctly handle newsegment events with stop==-1
    
    Fixes bug #645420.