GNOME Bugzilla – Bug 644512
[auparse] Add seeking
Last modified: 2011-06-15 22:43:35 UTC
Created attachment 183157 [details] [review] Add seeking to the auparse element I've added seeking to the auparse element. This is the first time I've submitted a patch against GStreamer, so I've probably got some things wrong. Thanks :)
Comment on attachment 183157 [details] [review] Add seeking to the auparse element Thanks for taking a stab on that missing feature. Some feedback on the stylistics aspects below: - please run gst-indent before making the patch. - use e.g. git diff <filename> >feature.patch - or add the changes you want (git add) and desctib them (git commit). Then do git format-patch origin to generate a patch series.
Created attachment 183333 [details] [review] Add seeking to the auparse element (formatted) I've formatted my changes with gst-indent and created the patch with `git diff'
Created attachment 186387 [details] [review] Add seeking to the auparse element (formatted) This is now a git patch (git format-patch origin). I have fixed two build issues. Still seeking ends up producing noise for me. Needs more work.
Created attachment 186391 [details] [review] Add seeking to the auparse element (formatted) The element also needs to now positively answer the seeking query.
Created attachment 186395 [details] [review] Add seeking to the auparse element (formatted) Something is still wrong here: gst_au_parse_handle_seek:<auparse0> seeking: 7775012 ... -1 gst_au_parse_handle_seek:<auparse0> seeking: 7853849 ... -1 gst_au_parse_handle_seek:<auparse0> seeking: 7932298 ... -1 this is byte positions. This would need to be on sample_size boundaries.
Created attachment 186398 [details] [review] Add seeking to the auparse element (formatted) Now it works for me :) Will push after freeze.