After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644512 - [auparse] Add seeking
[auparse] Add seeking
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-11 15:49 UTC by Chris E Jones
Modified: 2011-06-15 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add seeking to the auparse element (4.56 KB, patch)
2011-03-11 15:49 UTC, Chris E Jones
needs-work Details | Review
Add seeking to the auparse element (formatted) (4.84 KB, patch)
2011-03-14 12:27 UTC, Chris E Jones
none Details | Review
Add seeking to the auparse element (formatted) (5.25 KB, patch)
2011-04-20 19:35 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
Add seeking to the auparse element (formatted) (6.97 KB, patch)
2011-04-20 20:17 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
Add seeking to the auparse element (formatted) (7.24 KB, patch)
2011-04-20 22:11 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
none Details | Review
Add seeking to the auparse element (formatted) (7.74 KB, patch)
2011-04-20 22:33 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Chris E Jones 2011-03-11 15:49:13 UTC
Created attachment 183157 [details] [review]
Add seeking to the auparse element

I've added seeking to the auparse element.  This is the first time I've submitted a patch against GStreamer, so I've probably got some things wrong.  Thanks :)
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-13 20:49:09 UTC
Comment on attachment 183157 [details] [review]
Add seeking to the auparse element

Thanks for taking a stab on that missing feature.

Some feedback on the stylistics aspects below:
- please run gst-indent before making the patch.
- use e.g. git diff <filename> >feature.patch
- or add the changes you want (git add) and desctib them (git commit). Then do git format-patch origin to generate a patch series.
Comment 2 Chris E Jones 2011-03-14 12:27:07 UTC
Created attachment 183333 [details] [review]
Add seeking to the auparse element (formatted)

I've formatted my changes with gst-indent and created the patch with `git diff'
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-04-20 19:35:13 UTC
Created attachment 186387 [details] [review]
Add seeking to the auparse element (formatted)

This is now a git patch (git format-patch origin). I have fixed two build issues. Still seeking ends up producing noise for me. Needs more work.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2011-04-20 20:17:41 UTC
Created attachment 186391 [details] [review]
Add seeking to the auparse element (formatted)

The element also needs to now positively answer the seeking query.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2011-04-20 22:11:44 UTC
Created attachment 186395 [details] [review]
Add seeking to the auparse element (formatted)

Something is still wrong here:

gst_au_parse_handle_seek:<auparse0> seeking: 7775012 ... -1
gst_au_parse_handle_seek:<auparse0> seeking: 7853849 ... -1
gst_au_parse_handle_seek:<auparse0> seeking: 7932298 ... -1

this is byte positions. This would need to be on sample_size boundaries.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2011-04-20 22:33:00 UTC
Created attachment 186398 [details] [review]
Add seeking to the auparse element (formatted)

Now it works for me :) Will push after freeze.