After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644145 - File Location smart playlist don't work for the StartsWith case
File Location smart playlist don't work for the StartsWith case
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-07 18:27 UTC by Alex L. Mauer
Modified: 2011-12-11 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.84 KB, patch)
2011-12-11 18:53 UTC, Andrés G. Aragoneses (IRC: knocte) 		committed Details | Review

Description Alex L. Mauer 2011-03-07 18:27:16 UTC 
When creating a smart playlist using “Starts with” it is necessary to use URL syntax (file:///home/example) despite the fact that in every case (file properties as well as the File Location display column) Banshee simply uses the plain path (/home/example/Music/foo.mp3)
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2011-11-29 02:07:07 UTC 
Confirming.

(Working on it.)
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2011-12-11 18:52:59 UTC 
Found out the problem, it's not that it wasn't documented, because the user was not actually required to use the Uri syntax (it was just in the StartsWith case in which there was a bug). Going to attach a patch.
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2011-12-11 18:53:38 UTC 
Created attachment 203218 [details] [review]
Proposed patch
Comment 4 Bertrand Lorentz 2011-12-11 19:20:53 UTC 
Review of attachment 203218 [details] [review]:

Looks good, please commit.
Try to take my comment into account, but it's just a nitpick.

::: Hyena/Hyena.Query/Tests/QueryTests.cs
@@ +234,3 @@
 
+        [Test] // http://bugzilla.gnome.org/show_bug.cgi?id=644145
+        public void QueryUriWithStartsWithOpAddingFileUriSchemeToSqlQuery ()

That is an interesting method name... ;)
If you can find a shorter name, that'd be better.
Comment 5 Andrés G. Aragoneses (IRC: knocte) 2011-12-11 20:46:46 UTC 
Comment on attachment 203218 [details] [review]
Proposed patch

(In reply to comment #4)
> That is an interesting method name... ;)
> If you can find a shorter name, that'd be better.

Heh, fixed that, and committed.
Thanks for the review!
Comment 6 Andrés G. Aragoneses (IRC: knocte) 2011-12-11 20:51:18 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.