After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642963 - [dvdemux] time based upstream seek
[dvdemux] time based upstream seek
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal enhancement
: 0.10.29
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-22 13:46 UTC by Carsten Kroll
Modified: 2011-03-11 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dotime based seeks if upstream can handle it (2.00 KB, patch)
2011-02-22 13:46 UTC, Carsten Kroll
rejected Details | Review
Updated patch to follow the suggested logic (2.00 KB, patch)
2011-02-23 11:05 UTC, Carsten Kroll
committed Details | Review
fixes ref count issues introduced with previous patch (1.33 KB, patch)
2011-03-10 10:49 UTC, Carsten Kroll
needs-work Details | Review

Description Carsten Kroll 2011-02-22 13:46:02 UTC
Created attachment 181586 [details] [review]
dotime based seeks if upstream can handle it

This patch adds time based upstream element seeks to dv demuxer element. It does so by first quering for the seek supported method before passing the event on or converting it.
Comment 1 Edward Hervey 2011-02-22 14:04:34 UTC
The logic should be as follow:

If (seek format time)
  ret = push_it_upstream()
if ret == FALSE
  ret = do what's done right now
return ret
Comment 2 Carsten Kroll 2011-02-23 11:05:37 UTC
Created attachment 181681 [details] [review]
Updated patch to follow the suggested logic
Comment 3 Sebastian Dröge (slomo) 2011-02-24 12:57:48 UTC
commit d4eaff5e88c9b34a9e33ddaa9bb83859b2c37446
Author: Carsten Kroll <car@ximidi.com>
Date:   Thu Feb 24 13:56:04 2011 +0100

    dvdemux: First try if upstream handles TIME seeks before handling them here
    
    Fixes bug #642963.
Comment 4 Sebastian Dröge (slomo) 2011-02-24 12:58:01 UTC
Comment on attachment 181681 [details] [review]
Updated patch to follow the suggested logic

Please use "git format-patch" style patches in the future
Comment 5 Carsten Kroll 2011-03-10 10:49:12 UTC
Created attachment 183049 [details] [review]
fixes ref count issues introduced with previous patch
Comment 6 Carsten Kroll 2011-03-10 19:31:59 UTC
Review of attachment 183049 [details] [review]:

Doesn't look right. Will do some more analysis of the issue.
Comment 7 Sebastian Dröge (slomo) 2011-03-11 12:49:20 UTC
gst_dvdemux_handle_push_seek() is not supposed to take ownership of the event. This fixes it, and another memory leak that was caused by assuming that the function takes ownership of the event.

commit bc6c1bbbaba337538fd9cbaa307d6233ee03db4b
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Fri Mar 11 13:46:05 2011 +0100

    dvdemux: Fix refcount issues with the seek event
    
    Fixes bug #642963.