After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642667 - [playbin2] autoplug-factories code does not do what it claims to do
[playbin2] autoplug-factories code does not do what it claims to do
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal blocker
: 0.10.33
Assigned To: Sebastian Dröge (slomo)
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-18 13:20 UTC by Sebastian Dröge (slomo)
Modified: 2011-03-16 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2011-02-18 13:20:50 UTC
Hi,
the current autoplug-factories code in playbin2 claims:

/* Called when we must provide a list of factories to plug to @pad with @caps.
 * We first check if we have a sink that can handle the format and if we do, we
 * return NULL, to expose the pad. If we have no sink (or the sink does not
 * work), we return the list of elements that can connect. */

NULL is never returned but if there's a sink that supports the caps it will be returned together with the decoder elements.

Returning the sinks here will only confuse decodebin2 (if it really tries to autoplug a sink) and this should be changed. Returning NULL if a sink is found that supports the format would be an idea but not a very good one, this will stop autoplugging but it does not guarantee that playbin2 will actually use this sink. Instead the autoplug-factories code should probably only consider a/v decoders and the code in autoplug-continue already checks if the selected sink supports the caps.

OTOH this will not help much if no sink was manually set and the autosinks are used, but that's the same with the current code (or with the idea from the comment quoted above).
Comment 1 Sebastian Dröge (slomo) 2011-03-16 14:27:31 UTC
Actually it does what it claims to do, I missed some parts of the code